From patchwork Fri May 27 15:21:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zorro Lang X-Patchwork-Id: 9138663 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9CF8C60467 for ; Fri, 27 May 2016 15:21:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8FBF127BFA for ; Fri, 27 May 2016 15:21:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 84B32281A7; Fri, 27 May 2016 15:21:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0DBD727BFA for ; Fri, 27 May 2016 15:21:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbcE0PVa (ORCPT ); Fri, 27 May 2016 11:21:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48254 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbcE0PVa (ORCPT ); Fri, 27 May 2016 11:21:30 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 993CD486A5 for ; Fri, 27 May 2016 15:21:29 +0000 (UTC) Received: from localhost (vpn1-4-128.pek2.redhat.com [10.72.4.128]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4RFLS51007008; Fri, 27 May 2016 11:21:28 -0400 From: Zorro Lang To: fstests@vger.kernel.org Cc: cem@redhat.com, Zorro Lang Subject: [PATCH 2/2] xfs/006: new case to test xfs fail_at_unmount error handling Date: Fri, 27 May 2016 23:21:22 +0800 Message-Id: <1464362482-7704-2-git-send-email-zlang@redhat.com> In-Reply-To: <1464362482-7704-1-git-send-email-zlang@redhat.com> References: <1464362482-7704-1-git-send-email-zlang@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 27 May 2016 15:21:29 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP XFS bring in a new configuration under /sys/fs/xfs/error, named fail_at_unmount. It's used to stop unmount retrying forever when it hit IO error. This case try to unmount an faulty dm device, and to sure unmount won't retry forever if fail_at_unmount=1. Signed-off-by: Zorro Lang --- Hi, Thanks Carlos told this easy way(use dm error) to test this feature, or I will try to use dm thinp to reproduce unmount hit an ENOSPC error. That's more difficult to do. I haven't gotten some good ideas to test those /sys/fs/xfs/dm-X/error/ metadata/... configurations. If someone have good ideas, please let me know:) Thanks, Zorro tests/xfs/006 | 80 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/006.out | 2 ++ tests/xfs/group | 1 + 3 files changed, 83 insertions(+) create mode 100755 tests/xfs/006 create mode 100644 tests/xfs/006.out diff --git a/tests/xfs/006 b/tests/xfs/006 new file mode 100755 index 0000000..dafab50 --- /dev/null +++ b/tests/xfs/006 @@ -0,0 +1,80 @@ +#! /bin/bash +# FS QA Test 006 +# +# Test xfs' "fail at unmount" error handling configuration. Stop +# XFS retrying to writeback forever when unmount. +# +#----------------------------------------------------------------------- +# Copyright (c) 2016 YOUR NAME HERE. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/dmerror + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here +_supported_fs xfs +_supported_os Linux +_require_dm_target error +_require_scratch +_require_scratch_sys_fs error/fail_at_unmount + +# Format and mount +# The device is still a linear device at here +_scratch_mkfs > $seqres.full 2>&1 +_dmerror_init +_dmerror_mount + +# Enable fail_at_unmount +_enable_xfs_fail_at_unmount $DMERROR_DEV + +# make some IO at here. If these data still not writeback from +# journal to data, it will hit writeback error after load error +# tabel in next step. +_pwrite_byte 0x61 0 100M $SCRATCH_MNT/file >/dev/null +_dmerror_load_error_table + +# Even above data already all writeback, umount will cause XFS +# try to writeback something to root inode. It still can trigger +# umount fail. +_dmerror_unmount + +echo "Silence is golden" +_dmerror_cleanup + +# success, all done +status=0 +exit diff --git a/tests/xfs/006.out b/tests/xfs/006.out new file mode 100644 index 0000000..675c1b7 --- /dev/null +++ b/tests/xfs/006.out @@ -0,0 +1,2 @@ +QA output created by 006 +Silence is golden diff --git a/tests/xfs/group b/tests/xfs/group index f4c6816..39169ea 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -4,6 +4,7 @@ 004 db auto quick 005 auto quick 007 auto quota quick +006 auto quick unmount 008 rw ioctl auto quick 009 rw ioctl auto prealloc quick 010 auto quick repair