| Message ID | 1465409851-27969-2-git-send-email-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jun 08, 2016 at 08:17:31PM +0200, Christoph Hellwig wrote: > There is not i variable in scope, and the comments suggest the operation > is to be done on ${file}. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Oops. Thanks for the fix. :/ Looks good, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > tests/generic/186 | 2 +- > tests/generic/187 | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/generic/186 b/tests/generic/186 > index 70a0280..5de120a 100755 > --- a/tests/generic/186 > +++ b/tests/generic/186 > @@ -87,7 +87,7 @@ _fragment_freesp() > > # Try again anyway > avail=`_get_available_space $SCRATCH_MNT` > - $XFS_IO_PROG -fc "pwrite -S 0x65 0 $avail" ${file}.${i} > + $XFS_IO_PROG -fc "pwrite -S 0x65 0 $avail" ${file} > > # Punch out whatever we need > seq 1 $((nr * 4)) | while read f; do > diff --git a/tests/generic/187 b/tests/generic/187 > index 25cbcd9..3f534c8 100755 > --- a/tests/generic/187 > +++ b/tests/generic/187 > @@ -88,7 +88,7 @@ _fragment_freesp() > > # Try again anyway > avail=`_get_available_space $SCRATCH_MNT` > - $XFS_IO_PROG -fc "pwrite -S 0x65 0 $avail" ${file}.${i} > + $XFS_IO_PROG -fc "pwrite -S 0x65 0 $avail" ${file} > > # Punch out whatever we need > seq 1 $((nr * 4)) | while read f; do > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/generic/186 b/tests/generic/186 index 70a0280..5de120a 100755 --- a/tests/generic/186 +++ b/tests/generic/186 @@ -87,7 +87,7 @@ _fragment_freesp() # Try again anyway avail=`_get_available_space $SCRATCH_MNT` - $XFS_IO_PROG -fc "pwrite -S 0x65 0 $avail" ${file}.${i} + $XFS_IO_PROG -fc "pwrite -S 0x65 0 $avail" ${file} # Punch out whatever we need seq 1 $((nr * 4)) | while read f; do diff --git a/tests/generic/187 b/tests/generic/187 index 25cbcd9..3f534c8 100755 --- a/tests/generic/187 +++ b/tests/generic/187 @@ -88,7 +88,7 @@ _fragment_freesp() # Try again anyway avail=`_get_available_space $SCRATCH_MNT` - $XFS_IO_PROG -fc "pwrite -S 0x65 0 $avail" ${file}.${i} + $XFS_IO_PROG -fc "pwrite -S 0x65 0 $avail" ${file} # Punch out whatever we need seq 1 $((nr * 4)) | while read f; do
There is not i variable in scope, and the comments suggest the operation is to be done on ${file}. Signed-off-by: Christoph Hellwig <hch@lst.de> --- tests/generic/186 | 2 +- tests/generic/187 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)