From patchwork Mon Jun 20 13:24:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zorro Lang X-Patchwork-Id: 9187415 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 77DC760871 for ; Mon, 20 Jun 2016 13:33:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 63DD426992 for ; Mon, 20 Jun 2016 13:33:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 586562766D; Mon, 20 Jun 2016 13:33:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E03C9271FD for ; Mon, 20 Jun 2016 13:33:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752821AbcFTNdz (ORCPT ); Mon, 20 Jun 2016 09:33:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60661 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752941AbcFTNdy (ORCPT ); Mon, 20 Jun 2016 09:33:54 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 58A3063326 for ; Mon, 20 Jun 2016 13:24:39 +0000 (UTC) Received: from localhost (vpn1-6-174.pek2.redhat.com [10.72.6.174]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5KDOcQU032659; Mon, 20 Jun 2016 09:24:38 -0400 From: Zorro Lang To: fstests@vger.kernel.org Cc: sandeen@redhat.com, eguan@redhat.com, cem@redhat.com, Zorro Lang Subject: [PATCH v4 2/2] xfs/006: new case to test xfs fail_at_unmount error handling Date: Mon, 20 Jun 2016 21:24:33 +0800 Message-Id: <1466429073-10124-2-git-send-email-zlang@redhat.com> In-Reply-To: <1466429073-10124-1-git-send-email-zlang@redhat.com> References: <1466429073-10124-1-git-send-email-zlang@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 20 Jun 2016 13:24:39 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP XFS bring in a new configuration under /sys/fs/xfs/error, named fail_at_unmount from below commit: a5ea70d xfs: add configuration of error failure speed It's used to stop unmount retrying forever when it hit IO error. This case try to unmount an faulty dm device, and to sure unmount won't retry forever if fail_at_unmount=1. Signed-off-by: Zorro Lang --- Hi, V4 did below changes: 1) Due to common/rc changed, so change this case to use new function name. 2) Remove _pwrite_byte operation 3) After umount error device test, load working table back, and make sure fs consistent. Thanks, Zorro tests/xfs/006 | 81 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/006.out | 2 ++ tests/xfs/group | 1 + 3 files changed, 84 insertions(+) create mode 100755 tests/xfs/006 create mode 100644 tests/xfs/006.out diff --git a/tests/xfs/006 b/tests/xfs/006 new file mode 100755 index 0000000..be736f9 --- /dev/null +++ b/tests/xfs/006 @@ -0,0 +1,81 @@ +#! /bin/bash +# FS QA Test 006 +# +# Test xfs' "fail at unmount" error handling configuration. Stop +# XFS retrying to writeback forever when unmount. +# +#----------------------------------------------------------------------- +# Copyright (c) 2016 YOUR NAME HERE. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* + _dmerror_cleanup +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/dmerror + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here +_supported_fs xfs +_supported_os Linux +_require_dm_target error +_require_scratch + +_scratch_mkfs > $seqres.full 2>&1 +_require_fs_sysfs $SCRATCH_DEV error/fail_at_unmount + +# The device is still a linear device at here +_dmerror_init +_dmerror_mount + +# Enable fail_at_unmount +_set_fs_sysfs_param $DMERROR_DEV error/fail_at_unmount 1 + + +# umount will cause XFS try to writeback something to root inode. +# So after load error table, it can trigger umount fail. +_dmerror_load_error_table +_dmerror_unmount + +# Due to above operations cause fs inconsistent, that's expected. +# But we need fs be consistent before this case end. +_dmerror_load_working_table +_dmerror_mount +_dmerror_unmount + +echo "Silence is golden" + +# success, all done +status=0 +exit diff --git a/tests/xfs/006.out b/tests/xfs/006.out new file mode 100644 index 0000000..675c1b7 --- /dev/null +++ b/tests/xfs/006.out @@ -0,0 +1,2 @@ +QA output created by 006 +Silence is golden diff --git a/tests/xfs/group b/tests/xfs/group index f4c6816..39169ea 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -4,6 +4,7 @@ 004 db auto quick 005 auto quick 007 auto quota quick +006 auto quick unmount 008 rw ioctl auto quick 009 rw ioctl auto prealloc quick 010 auto quick repair