From patchwork Tue Sep 20 03:15:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Yang X-Patchwork-Id: 9340947 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 595C56022E for ; Tue, 20 Sep 2016 03:20:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4C16A29BDE for ; Tue, 20 Sep 2016 03:20:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3EE0229BE8; Tue, 20 Sep 2016 03:20:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D07629BDE for ; Tue, 20 Sep 2016 03:20:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752511AbcITDUg (ORCPT ); Mon, 19 Sep 2016 23:20:36 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:5984 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752487AbcITDUf (ORCPT ); Mon, 19 Sep 2016 23:20:35 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="11135463" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 20 Sep 2016 11:20:30 +0800 Received: from G08CNEXCHPEKD03.g08.fujitsu.local (unknown [10.167.33.85]) by cn.fujitsu.com (Postfix) with ESMTP id 1B4244623467; Tue, 20 Sep 2016 11:20:30 +0800 (CST) Received: from localhost.localdomain (10.167.220.69) by G08CNEXCHPEKD03.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.279.2; Tue, 20 Sep 2016 11:20:29 +0800 From: Xiao Yang To: CC: , , Xiao Yang Subject: [PATCH v2] common/rc: fix fsmap check Date: Tue, 20 Sep 2016 11:15:39 +0800 Message-ID: <1474341339-22956-1-git-send-email-yangx.jy@cn.fujitsu.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <20160920030332.GD10172@birch.djwong.org> References: <20160920030332.GD10172@birch.djwong.org> MIME-Version: 1.0 X-Originating-IP: [10.167.220.69] X-yoursite-MailScanner-ID: 1B4244623467.A5BA9 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: yangx.jy@cn.fujitsu.com Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I got an error about $TEST_DIR being a directory when running xfs/273, because xfs_io tried to open the directory first before it parsed the -T options. I get rid of -T to fix it because getfsmap doesn't care if it's run against a file or a directory. Signed-off-by: Xiao Yang --- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/rc b/common/rc index 13afc6a..ec5d73e 100644 --- a/common/rc +++ b/common/rc @@ -2049,7 +2049,7 @@ _require_xfs_io_command() _notrun "xfs_io $command support is missing" ;; "fsmap" ) - testio=`$XFS_IO_PROG -T -F -c "fsmap" \ + testio=`$XFS_IO_PROG -F -c "fsmap" \ $TEST_DIR 2>&1` echo $testio | egrep -q "Inappropriate ioctl" && \ _notrun "xfs_io $command support is missing"