| Message ID | 1474348992-27909-1-git-send-email-yangx.jy@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 20, 2016 at 01:23:12PM +0800, Xiao Yang wrote: > We don't need -T to detect GETFSMAP and the flag doesn't exist > on really old versions of xfs_io, so just get rid of it. > > Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com> > --- > common/rc | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/common/rc b/common/rc > index 13afc6a..52a75c5 100644 > --- a/common/rc > +++ b/common/rc > @@ -2049,8 +2049,7 @@ _require_xfs_io_command() > _notrun "xfs_io $command support is missing" > ;; > "fsmap" ) > - testio=`$XFS_IO_PROG -T -F -c "fsmap" \ > - $TEST_DIR 2>&1` > + testio=`$XFS_IO_PROG -f -c "fsmap" $testfile 2>&1` Seems fine to me, Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> > echo $testio | egrep -q "Inappropriate ioctl" && \ > _notrun "xfs_io $command support is missing" > ;; > -- > 1.8.3.1 > > > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/common/rc b/common/rc index 13afc6a..52a75c5 100644 --- a/common/rc +++ b/common/rc @@ -2049,8 +2049,7 @@ _require_xfs_io_command() _notrun "xfs_io $command support is missing" ;; "fsmap" ) - testio=`$XFS_IO_PROG -T -F -c "fsmap" \ - $TEST_DIR 2>&1` + testio=`$XFS_IO_PROG -f -c "fsmap" $testfile 2>&1` echo $testio | egrep -q "Inappropriate ioctl" && \ _notrun "xfs_io $command support is missing" ;;
We don't need -T to detect GETFSMAP and the flag doesn't exist on really old versions of xfs_io, so just get rid of it. Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com> --- common/rc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)