| Message ID | 1475218726-22265-1-git-send-email-zlang@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/xfs/032 b/tests/xfs/032 index 6216379..4b675ee 100755 --- a/tests/xfs/032 +++ b/tests/xfs/032 @@ -60,6 +60,11 @@ while [ $SECTORSIZE -le $PAGESIZE ]; do echo "=== Sector size $SECTORSIZE Block size $BLOCKSIZE ==" >> $seqres.full _scratch_mkfs -s size=$SECTORSIZE -b size=$BLOCKSIZE -d size=1g >> $seqres.full 2>&1 + # Maybe return error at here, e.g: mkfs.xfs -m crc=1 -b size=512 + if [ $? -ne 0 ]; then + BLOCKSIZE=$(($BLOCKSIZE * 2)) + continue + fi _scratch_mount # light population of the fs $FSSTRESS_PROG -n 100 -d $SCRATCH_MNT >> $seqres.full 2>&1
If test on a 512b sector size device, xfs/032 will try to do: mkfs.xfs -s size=512 -b size=512 ... The 512b block size is not acceptable for V5 XFS. So if mkfs.xfs fails, try next block size (blksize *= 2) directly. Signed-off-by: Zorro Lang <zlang@redhat.com> --- V1 try to find the minimum acceptable block size at first, V2 drop that method, and then *continue* the test if _scratch_mkfs return error. Thanks, Zorro tests/xfs/032 | 5 +++++ 1 file changed, 5 insertions(+)