From patchwork Mon Dec 12 08:45:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 9470177 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5334A60760 for ; Mon, 12 Dec 2016 08:45:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D68A28451 for ; Mon, 12 Dec 2016 08:45:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 420C02845C; Mon, 12 Dec 2016 08:45:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BC77528451 for ; Mon, 12 Dec 2016 08:45:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753924AbcLLIp3 (ORCPT ); Mon, 12 Dec 2016 03:45:29 -0500 Received: from mail-wj0-f193.google.com ([209.85.210.193]:34439 "EHLO mail-wj0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752638AbcLLIp1 (ORCPT ); Mon, 12 Dec 2016 03:45:27 -0500 Received: by mail-wj0-f193.google.com with SMTP id xy5so10227790wjc.1; Mon, 12 Dec 2016 00:45:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=NSEJ7GshWdicQqKgKf0hpXNV/3c14odS0IAb+R/PgxI=; b=WyEdQYAyP5JxAsYJj+3ftoayUk95Y+1WQm1nEAiZf7C6by+660FhzXNcDEMfcX9QST ktLD/COpDJ8MK4aK403ZsRrih7OcLnjlYNwuc9MvjSfqVD2x0sfl3YSLsQUQSmZu8218 fzZw92SVFYDcIZRiOqu5jrSvcDD4JDzbyryBxlgUePKIlARwJddBTnHT+gPXgZoZokCn ISI7WzUD4vIHiUvMTGAC/RIE63qE2GuSjvOEvP7GTiuMMK8R5DUsfYNEdSFfAaArn3DZ SDaEFgYOTG+ALjVFHtdF9W9AEWzaVD65+T8tlAlHVOg9zLbJ8+pEft0yTshIDbBGgw8c vBFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=NSEJ7GshWdicQqKgKf0hpXNV/3c14odS0IAb+R/PgxI=; b=HiZqiIAbA+tjL80A51kHDdaxHJpiJq1DJdkiIyMZvyXBBLeHDGh2cXz8Dme+puFGIr /Zo6qDNKFvfQ/ymaMNGQclQYcb3lxh+sXiMEsJ7qetGu2G4e+9wE8MaaCiSVQwsEcNnA H9bNct5tk8NMYjCm6ihBz6uzhoRb/V1ogJsJ35FMxuw1xEOHDbj11nRuZmJ7JUUlaBBm BdOezIUk5b/2nkiD+WDKhbcii7YjK1tAnvOnidzhR4aHEFFJSnLFyTIJRYv4gteKL0FZ tcOw42S7udMRtCDxpW10eIPNI1DqdL8vEr9x9YmvcapLBXO/me85BcwY2DQ2Ypocfjtw /8yg== X-Gm-Message-State: AKaTC006PlBi0a4v1Euu0rBYoWNFYDso3Lt2UyZlcWz9mCeC1+pgZ174BjgvPjFc7zvPcg== X-Received: by 10.194.146.228 with SMTP id tf4mr11398787wjb.183.1481532326158; Mon, 12 Dec 2016 00:45:26 -0800 (PST) Received: from amir-VirtualBox.ctera.local (bzq-82-81-193-202.cablep.bezeqint.net. [82.81.193.202]) by smtp.gmail.com with ESMTPSA id u81sm34284108wmu.10.2016.12.12.00.45.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Dec 2016 00:45:25 -0800 (PST) From: Amir Goldstein To: Eryu Guan Cc: Miklos Szeredi , linux-unionfs@vger.kernel.org, fstests@vger.kernel.org Subject: [PATCH v3] overlay: test unstable inode number Date: Mon, 12 Dec 2016 10:45:06 +0200 Message-Id: <1481532306-26938-1-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Introduce a new test to demonstrate a known issue with overlayfs: - stat file A shows inode number X - modify A to trigger copy up - stat file A shows inode number Y != X Also test if d_ino of readdir entries changes after copy up. There is a POC patch by Miklos Szeredi that fixes this issue. Not dealing with hardlinks here, because there is more to test then stable inode number. Hardlinks will get a test of their own. --- tests/overlay/018 | 101 ++++++++++++++++++++++++++++++++++++++++++++++++++ tests/overlay/018.out | 7 ++++ tests/overlay/group | 1 + 3 files changed, 109 insertions(+) create mode 100755 tests/overlay/018 create mode 100644 tests/overlay/018.out v3: - test also special device files - document not testing hardlinks v2: - use arbitrary uid for chown diff --git a/tests/overlay/018 b/tests/overlay/018 new file mode 100755 index 0000000..230245b --- /dev/null +++ b/tests/overlay/018 @@ -0,0 +1,101 @@ +#! /bin/bash +# FSQA Test No. 018 +# +# Test unstable inode number +# +# This simple test demonstrates a known issue with overlayfs: +# - stat file A shows inode number X +# - modify A to trigger copy up +# - stat file A shows inode number Y != X +# +# Also test if d_ino of readdir entries changes after copy up. +# +#----------------------------------------------------------------------- +# +# Copyright (C) 2016 CTERA Networks. All Rights Reserved. +# Author: Amir Goldstein +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs overlay +_supported_os Linux +_require_scratch + +rm -f $seqres.full + +_scratch_mkfs >>$seqres.full 2>&1 + +# Create our test files. +# Not dealing with hardlinks here, because there is more to test +# then stable inode number. +# Hardlinks will get a test of their own. +lowerdir=$SCRATCH_DEV/$OVERLAY_LOWER_DIR +mkdir -p $lowerdir +mkdir $lowerdir/dir +touch $lowerdir/file +ln -s $lowerdir/file $lowerdir/symlink +mknod $lowerdir/chrdev c 1 1 +mknod $lowerdir/blkdev b 1 1 +mknod $lowerdir/fifo p + + +_scratch_mount + +cd $SCRATCH_MNT + +rm -f $tmp.before $tmp.after + +# Test stable stat(2) st_ino + +# Record inode numbers before and after copy up +for f in dir file symlink chrdev blkdev fifo; do + ls -id $f >> $tmp.before + # chown -h modifies all those file types + chown -h 100 $f + ls -id $f >> $tmp.after +done + +# Test stable readdir(3)/getdents(2) d_ino + +# find by inode number - expect to find file by inode number +cat $tmp.before | while read ino f; do + find $f -inum $ino -maxdepth 0 +done + +# Compare before..after - expect silence +diff $tmp.before $tmp.after + +status=0 +exit diff --git a/tests/overlay/018.out b/tests/overlay/018.out new file mode 100644 index 0000000..bf4bce8 --- /dev/null +++ b/tests/overlay/018.out @@ -0,0 +1,7 @@ +QA output created by 018 +dir +file +symlink +chrdev +blkdev +fifo diff --git a/tests/overlay/group b/tests/overlay/group index 5740d2a..683b2fc 100644 --- a/tests/overlay/group +++ b/tests/overlay/group @@ -19,3 +19,4 @@ 014 auto quick copyup 015 auto quick whiteout 016 auto quick +018 auto quick