From patchwork Tue Dec 13 06:18:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 9471823 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2B3A960760 for ; Tue, 13 Dec 2016 06:18:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D27C28528 for ; Tue, 13 Dec 2016 06:18:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 10AEB28539; Tue, 13 Dec 2016 06:18:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8DC4A28528 for ; Tue, 13 Dec 2016 06:18:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752682AbcLMGSx (ORCPT ); Tue, 13 Dec 2016 01:18:53 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35663 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752478AbcLMGSx (ORCPT ); Tue, 13 Dec 2016 01:18:53 -0500 Received: by mail-wm0-f67.google.com with SMTP id a20so16067974wme.2; Mon, 12 Dec 2016 22:18:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=9uq2Fsr8O3r6qPTFKhkodeqRSnUJGbNit6+d7lVzotQ=; b=B6jqK1UbhB0evWbVh+dhhVtmQTz5l3ckkQ+mYgk2YtyekgyUkW/JYzTfaKpC4NaLyw 0QKIhpM5CIcza/XbPkg4VkGwEtthgirtrPBggCiX9fzJ7/o6VgzJDb74ySV6JN4bCToP 8h6lRbfNs0yrfOSFpJHJ06BoIKiZ3o1dd5U5KpNzVShPbBez8AmwXFpbRlWF/nYTTG0n ien8w8+kg0O5weurfqNx0V7zsjfVyHK9ezqVH03R0FU/E9TzKPi4rWY3KA/H6pKbEVBY tET8f4ZZOLmJ31Cy16ijsEvRKTMCUJpv9QX+Rjlw7Ib7uAWT2OYxrJGl7tzq77wqauE0 q80g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=9uq2Fsr8O3r6qPTFKhkodeqRSnUJGbNit6+d7lVzotQ=; b=HAPIYX8m0XW5SkqWQCQkRrrs7pWiwo8Df4q1aAG9/D46zO2Iw4uaczf1iIpT19Pfdk fEo2lEceyW4ZMvv53FQ/HfNJKtoODY+zSUwVC16JaF9RZ8BqqV1q6tUhEB2e+x1uIjSc WBhaR6VkX0E2kejvfej4cuuNYDdVZBtff5TL4+9Ge43wroqaAzhO+TCYY2Wbj66g2ozC F+bCRQvPLYiEVkGhOqMIKmXHkVIYFJunsytXHnZSogvhmD2kmnfVtziWw9fIZ4meqhI6 uQz4YqkpYaq0r65Mm4NUr8k3NzbvKvBOsDyk5W8RBMw/KNJ5fkXIgGFTy3IFMI095Zra 74hw== X-Gm-Message-State: AKaTC02LgyevfPypbx3XPU8B3wWopkVh7yQb1Ku/itW7xZW2gjRV5AAWOahtpged7hbWPQ== X-Received: by 10.28.63.150 with SMTP id m144mr982086wma.96.1481609931265; Mon, 12 Dec 2016 22:18:51 -0800 (PST) Received: from amir-VirtualBox.Home (bzq-109-65-102-174.red.bezeqint.net. [109.65.102.174]) by smtp.gmail.com with ESMTPSA id vr9sm60519340wjc.35.2016.12.12.22.18.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 12 Dec 2016 22:18:50 -0800 (PST) From: Amir Goldstein To: Eryu Guan Cc: Miklos Szeredi , linux-unionfs@vger.kernel.org, fstests@vger.kernel.org Subject: [PATCH v3] overlay: test unstable inode number Date: Tue, 13 Dec 2016 08:18:29 +0200 Message-Id: <1481609909-12433-1-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Introduce a new test to demonstrate a known issue with overlayfs: - stat file A shows inode number X - modify A to trigger copy up - stat file A shows inode number Y != X Also test if d_ino of readdir entries changes after copy up. There is a POC patch by Miklos Szeredi that fixes this issue. Not dealing with hardlinks here, because there is more to test then stable inode number. Hardlinks will get a test of their own. Signed-off-by: Amir Goldstein --- tests/overlay/018 | 99 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/overlay/018.out | 7 ++++ tests/overlay/group | 1 + 3 files changed, 107 insertions(+) create mode 100755 tests/overlay/018 create mode 100644 tests/overlay/018.out v3: - avoid cd into $SCRATCH_MNT v2: - use arbitrary uid for chown diff --git a/tests/overlay/018 b/tests/overlay/018 new file mode 100755 index 0000000..92fb63d --- /dev/null +++ b/tests/overlay/018 @@ -0,0 +1,99 @@ +#! /bin/bash +# FSQA Test No. 018 +# +# Test unstable inode number +# +# This simple test demonstrates a known issue with overlayfs: +# - stat file A shows inode number X +# - modify A to trigger copy up +# - stat file A shows inode number Y != X +# +# Also test if d_ino of readdir entries changes after copy up. +# +#----------------------------------------------------------------------- +# +# Copyright (C) 2016 CTERA Networks. All Rights Reserved. +# Author: Amir Goldstein +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs overlay +_supported_os Linux +_require_scratch + +rm -f $seqres.full + +_scratch_mkfs >>$seqres.full 2>&1 + +# Create our test files. +# Not dealing with hardlinks here, because there is more to test +# then stable inode number. +# Hardlinks will get a test of their own. +lowerdir=$SCRATCH_DEV/$OVERLAY_LOWER_DIR +mkdir -p $lowerdir +mkdir $lowerdir/dir +touch $lowerdir/file +ln -s $lowerdir/file $lowerdir/symlink +mknod $lowerdir/chrdev c 1 1 +mknod $lowerdir/blkdev b 1 1 +mknod $lowerdir/fifo p + + +_scratch_mount + + +rm -f $tmp.before $tmp.after + +# Test stable stat(2) st_ino + +# Record inode numbers before and after copy up +for f in dir file symlink chrdev blkdev fifo; do + ls -id $SCRATCH_MNT/$f >> $tmp.before + # chown -h modifies all those file types + chown -h 100 $SCRATCH_MNT/$f + ls -id $SCRATCH_MNT/$f >> $tmp.after +done + +# Test stable readdir(3)/getdents(2) d_ino + +# find by inode number - expect to find file by inode number +cat $tmp.before | while read ino f; do + find $f -inum $ino -maxdepth 0 | _filter_scratch +done + +# Compare before..after - expect silence +diff $tmp.before $tmp.after + +status=0 +exit diff --git a/tests/overlay/018.out b/tests/overlay/018.out new file mode 100644 index 0000000..0e5132c --- /dev/null +++ b/tests/overlay/018.out @@ -0,0 +1,7 @@ +QA output created by 018 +SCRATCH_MNT/dir +SCRATCH_MNT/file +SCRATCH_MNT/symlink +SCRATCH_MNT/chrdev +SCRATCH_MNT/blkdev +SCRATCH_MNT/fifo diff --git a/tests/overlay/group b/tests/overlay/group index 7cb2615..fb6610d 100644 --- a/tests/overlay/group +++ b/tests/overlay/group @@ -19,3 +19,4 @@ 014 auto quick copyup 015 auto quick whiteout 016 auto quick copyup +018 auto quick copyup