From patchwork Fri Jan 6 19:39:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Foster X-Patchwork-Id: 9501677 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7A0516021C for ; Fri, 6 Jan 2017 19:40:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55CEA28503 for ; Fri, 6 Jan 2017 19:40:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4747528512; Fri, 6 Jan 2017 19:40:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D54AA28503 for ; Fri, 6 Jan 2017 19:40:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932235AbdAFTk3 (ORCPT ); Fri, 6 Jan 2017 14:40:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50178 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760042AbdAFTk2 (ORCPT ); Fri, 6 Jan 2017 14:40:28 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8A6FD9D773; Fri, 6 Jan 2017 19:39:32 +0000 (UTC) Received: from bfoster.bfoster (dhcp-41-20.bos.redhat.com [10.18.41.20]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v06JdWMn017560; Fri, 6 Jan 2017 14:39:32 -0500 Received: by bfoster.bfoster (Postfix, from userid 1000) id D9C7512019A; Fri, 6 Jan 2017 14:39:30 -0500 (EST) From: Brian Foster To: fstests@vger.kernel.org Cc: linux-xfs@vger.kernel.org Subject: [PATCH] generic: test racing getxattr requests against xattr add/remove Date: Fri, 6 Jan 2017 14:39:30 -0500 Message-Id: <1483731570-55208-1-git-send-email-bfoster@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 06 Jan 2017 19:39:32 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This test reproduces a bug in XFS where a getxattr of an existing xattr returns failure due to a race with a setxattr that causes inode attribute fork conversion. Signed-off-by: Brian Foster --- tests/generic/402 | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/402.out | 2 ++ tests/generic/group | 1 + 3 files changed, 88 insertions(+) create mode 100755 tests/generic/402 create mode 100644 tests/generic/402.out diff --git a/tests/generic/402 b/tests/generic/402 new file mode 100755 index 0000000..b9739bb --- /dev/null +++ b/tests/generic/402 @@ -0,0 +1,85 @@ +#! /bin/bash +# FS QA Test 402 +# +# Test racing getxattr requests against large xattr add and remove loop. This +# reproduces a bug on XFS where a getxattr of an existing attribute spuriously +# returned failure due to races with attribute fork conversion. +# +#----------------------------------------------------------------------- +# Copyright (c) 2017 Red hat, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/attr + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +# Modify as appropriate. +_supported_fs generic +_supported_os IRIX Linux +_require_scratch +_require_attrs + +_scratch_mkfs > $seqres.full 2>&1 || _fail "mkfs" +_scratch_mount || _fail "mount" + +# create xattr small enough for local format on XFS +touch $SCRATCH_MNT/file +$SETFATTR_PROG -n trusted.small -v a $SCRATCH_MNT/file + +# start a background getxattr loop for the existing xattr +while [ true ]; do + $GETFATTR_PROG --absolute-names -n trusted.small $SCRATCH_MNT/file \ + > /dev/null || break +done & +getfattr_pid=$! + +# while the above is spinning, add and remove a large attribute to cause back +# and forth inode attribute fork conversion +largeval=`for i in $(seq 0 511); do echo -n a; done` +for i in $(seq 0 99); do + $SETFATTR_PROG -n trusted.big -v $largeval $SCRATCH_MNT/file + $SETFATTR_PROG -x trusted.big $SCRATCH_MNT/file +done + +kill -9 $getfattr_pid > /dev/null 2>&1 +wait > /dev/null 2>&1 + +echo Silence is golden + +# success, all done +status=0 +exit diff --git a/tests/generic/402.out b/tests/generic/402.out new file mode 100644 index 0000000..28e1501 --- /dev/null +++ b/tests/generic/402.out @@ -0,0 +1,2 @@ +QA output created by 402 +Silence is golden diff --git a/tests/generic/group b/tests/generic/group index 64dae2b..eb11c0f 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -404,3 +404,4 @@ 399 auto encrypt 400 auto quick quota 401 auto quick +402 auto quick attr