From patchwork Thu Feb 16 19:57:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 9578281 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3FF1460244 for ; Thu, 16 Feb 2017 19:57:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3107127FAE for ; Thu, 16 Feb 2017 19:57:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 25FE728159; Thu, 16 Feb 2017 19:57:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C3C7427D0C for ; Thu, 16 Feb 2017 19:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933083AbdBPT5Z (ORCPT ); Thu, 16 Feb 2017 14:57:25 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:35979 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933136AbdBPT5Y (ORCPT ); Thu, 16 Feb 2017 14:57:24 -0500 Received: by mail-wr0-f195.google.com with SMTP id z61so2495488wrc.3; Thu, 16 Feb 2017 11:57:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=04NJMlEPSzF4y9OrVZ4P0S9QYCoGbduyQQEJfkVm98k=; b=s5VJQP3NUPf7unqX9/5f7rm3TV3bYiFtVINistSWsbMVcbHg9lEFICUIWgRIR4KN0r s7u7tfuVRRUGyp4ksQgGHc47AzfK+9IvgTi1pSfhZam41kzuB8jF4wSwMcAJbFVVC6gw rw3IjkcBQVTKF3UY2w/XRuUD4nkYJCqlxMC2Ml+ENWSZdyjsnE0YTQ5K63i8wlAVsAM/ GUqy2trfRB1ECGWQA90QIrA0uZ1BNQ4xrzQoqKzVXsQMPlfgvL2VeXrfAlC7rgihtNFJ ZUycxsipI2P0RUcr11A9E6n7OJwmYAB+PYua4vuTSJWezwgsPSkaPXPu1FzzyNnOTot1 3j2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=04NJMlEPSzF4y9OrVZ4P0S9QYCoGbduyQQEJfkVm98k=; b=QyaWB/RKAOcAxvEj0urxn7SUP5GpZI4ry78fd4fSnDqyBmIoRSjXuHMvCmtXwJY1Zd yQkE/zhGmzosoI8wA5ZTEFL0Qus8oCGsO5QUx2bBkoq1duBdRiiQiD2dmcC03DBilDm5 wrd6ka+nkIJeNkQlGTh381BZRI+Ow31plVx/auF2EKX56tlru+ic/d6/FYNAN+UOhXHw qCtByAQyViCesReoJS7TfQqLuEVsymeBhJ5SihIlgrSLVD+VO1kuJ6LtB2R7jpQYesho 9RoHKmiGq+6nM7sBNocYovGmo/3ZMCoh+6Cyxso3Z2ttvWkIKqjpEx1XqLl3L2H5Le7r VQ/Q== X-Gm-Message-State: AMke39mAgOE3dtAsVHEqsCHY/8USkt9E5hjdKsujzoGPhsy35vWAAVmuF3fwY3lsyQTSIQ== X-Received: by 10.223.136.50 with SMTP id d47mr4330341wrd.167.1487275043118; Thu, 16 Feb 2017 11:57:23 -0800 (PST) Received: from localhost.localdomain (bzq-79-176-143-83.red.bezeqint.net. [79.176.143.83]) by smtp.gmail.com with ESMTPSA id c9sm1437210wmf.18.2017.02.16.11.57.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 16 Feb 2017 11:57:22 -0800 (PST) From: Amir Goldstein To: Eryu Guan Cc: Miklos Szeredi , linux-unionfs@vger.kernel.org, fstests@vger.kernel.org Subject: [PATCH v4 03/10] fstests: canonicalize mount points on every config section Date: Thu, 16 Feb 2017 21:57:01 +0200 Message-Id: <1487275028-29885-4-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1487275028-29885-1-git-send-email-amir73il@gmail.com> References: <1487275028-29885-1-git-send-email-amir73il@gmail.com> Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Create helper _canonicalize_mountpoint() to check and canonicalize a mount point path. Use helper to canonicalize TEST_DIR and SCRATCH_MNT after parse of every config section. This is needed for overlay base fs mount. Signed-off-by: Amir Goldstein --- common/config | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/common/config b/common/config index fa89f42..bfd6429 100644 --- a/common/config +++ b/common/config @@ -454,6 +454,20 @@ _check_device() fi } +# check and return a canonical mount point path +_canonicalize_mountpoint() +{ + local name=$1 + local dir=$2 + + if [ ! -d "$dir" ]; then + _fatal "common/config: $name ($dir) is not a directory" + fi + + # this follows symlinks and removes all trailing "/"s + readlink -e "$dir" +} + # Parse config section options. This function will parse all the configuration # within a single section which name is passed as an argument. For section # name format see comments in get_config_sections(). @@ -542,10 +556,7 @@ get_next_config() { fi _check_device TEST_DEV required $TEST_DEV - if [ ! -d "$TEST_DIR" ]; then - echo "common/config: Error: \$TEST_DIR ($TEST_DIR) is not a directory" - exit 1 - fi + export TEST_DIR=`_canonicalize_mountpoint TEST_DIR $TEST_DIR` # a btrfs tester will set only SCRATCH_DEV_POOL, we will put first of its dev # to SCRATCH_DEV and rest to SCRATCH_DEV_POOL to maintain the backward compatibility @@ -560,10 +571,7 @@ get_next_config() { fi _check_device SCRATCH_DEV optional $SCRATCH_DEV - if [ ! -z "$SCRATCH_MNT" -a ! -d "$SCRATCH_MNT" ]; then - echo "common/config: Error: \$SCRATCH_MNT ($SCRATCH_MNT) is not a directory" - exit 1 - fi + export SCRATCH_MNT=`_canonicalize_mountpoint SCRATCH_MNT $SCRATCH_MNT` if [ -n "$USE_EXTERNAL" ]; then _check_device TEST_RTDEV optional $TEST_RTDEV @@ -590,12 +598,12 @@ if [ -z "$CONFIG_INCLUDED" ]; then [ -z "$TEST_FS_MOUNT_OPTS" ] && _test_mount_opts [ -z "$MKFS_OPTIONS" ] && _mkfs_opts [ -z "$FSCK_OPTIONS" ] && _fsck_opts +else + # canonicalize the mount points + # this follows symlinks and removes all trailing "/"s + export TEST_DIR=`_canonicalize_mountpoint TEST_DIR $TEST_DIR` + export SCRATCH_MNT=`_canonicalize_mountpoint SCRATCH_MNT $SCRATCH_MNT` fi -# canonicalize the mount points -# this follows symlinks and removes all trailing "/"s -export TEST_DIR=`readlink -e "$TEST_DIR"` -export SCRATCH_MNT=`readlink -e "$SCRATCH_MNT"` - # make sure this script returns success /bin/true