From patchwork Mon Feb 20 08:48:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Murphy Zhou X-Patchwork-Id: 9582173 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 454586057F for ; Mon, 20 Feb 2017 08:49:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3569628840 for ; Mon, 20 Feb 2017 08:49:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2A58928861; Mon, 20 Feb 2017 08:49:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C0FC828840 for ; Mon, 20 Feb 2017 08:49:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752348AbdBTItK (ORCPT ); Mon, 20 Feb 2017 03:49:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44042 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752326AbdBTItI (ORCPT ); Mon, 20 Feb 2017 03:49:08 -0500 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8199D8046A; Mon, 20 Feb 2017 08:49:09 +0000 (UTC) Received: from localhost (unknown [10.66.12.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id EDF4015A8C; Mon, 20 Feb 2017 08:49:08 +0000 (UTC) From: Xiong Zhou To: fstests@vger.kernel.org Cc: linux-unionfs@vger.kernel.org, mszeredi@redhat.com, Xiong Zhou Subject: [xfstests v3 4/8] overlay: permission check with cached acls in tmpfs Date: Mon, 20 Feb 2017 16:48:40 +0800 Message-Id: <1487580524-21503-5-git-send-email-xzhou@redhat.com> In-Reply-To: <1487580524-21503-1-git-send-email-xzhou@redhat.com> References: <1487580524-21503-1-git-send-email-xzhou@redhat.com> X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 20 Feb 2017 08:49:09 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP tmpfs does not implement ->get_acl method, overlayfs need to get its cached acls in permission check when lower or upper fs is tmpfs. CC: Miklos Szeredi Signed-off-by: Xiong Zhou --- tests/overlay/025 | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++ tests/overlay/025.out | 2 ++ tests/overlay/group | 1 + 3 files changed, 88 insertions(+) create mode 100755 tests/overlay/025 create mode 100644 tests/overlay/025.out diff --git a/tests/overlay/025 b/tests/overlay/025 new file mode 100755 index 0000000..69d7f91 --- /dev/null +++ b/tests/overlay/025 @@ -0,0 +1,85 @@ +#! /bin/bash +# FS QA Test 025 +# +# Overlayfs failed to get posix acls if lower or upper +# fs is tmpfs. +# Kernel commit below fixed it. +# 5201dc449e4b ovl: use cached acl on underlying layer +# +# This reproducer was originally written by +# Miklos Szeredi +# +#----------------------------------------------------------------------- +# Copyright (c) 2017 Red Hat Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + $UMOUNT_PROG $tmp/tmpfs/mnt + $UMOUNT_PROG $tmp/tmpfs + rm -rf $tmp + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +# Modify as appropriate. +_supported_fs overlay +_supported_os Linux +_require_user + +# create a tmpfs under $tmp +mkdir -p $tmp/tmpfs +$MOUNT_PROG -t tmpfs tmpfs $tmp/tmpfs || \ + _notrun "this test requires a valid tmpfs" + +pushd $tmp/tmpfs > /dev/null 2>&1 + +mkdir -p lower upper work mnt +mkdir -p -m 0 upper/testd +# grant permission for $qa_user +setfacl -m u:$qa_user:rx upper/testd + +# mount overlay using dirs in tmpfs +_overlay_mount_dirs lower upper work overlay mnt + +popd > /dev/null 2>&1 + +# user accessing test dir, should be Okay +_user_do "ls $tmp/tmpfs/mnt/testd" + +echo "Silence is golden" +# success, all done +status=0 +exit diff --git a/tests/overlay/025.out b/tests/overlay/025.out new file mode 100644 index 0000000..3d70951 --- /dev/null +++ b/tests/overlay/025.out @@ -0,0 +1,2 @@ +QA output created by 025 +Silence is golden diff --git a/tests/overlay/group b/tests/overlay/group index 0563a04..82fe69e 100644 --- a/tests/overlay/group +++ b/tests/overlay/group @@ -27,3 +27,4 @@ 022 auto quick 023 auto quick attr 024 auto quick +025 auto quick attr