From patchwork Fri Apr 28 08:24:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 9704027 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 59D72602B7 for ; Fri, 28 Apr 2017 08:25:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 49E3828602 for ; Fri, 28 Apr 2017 08:25:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3EF5628663; Fri, 28 Apr 2017 08:25:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB06228602 for ; Fri, 28 Apr 2017 08:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034813AbdD1IZA (ORCPT ); Fri, 28 Apr 2017 04:25:00 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36189 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034791AbdD1IYr (ORCPT ); Fri, 28 Apr 2017 04:24:47 -0400 Received: by mail-wr0-f195.google.com with SMTP id v42so6262537wrc.3; Fri, 28 Apr 2017 01:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pWpb99znXW/wwUK6jsz+nxy8SwKlRv7VVvwNtWgOIXU=; b=SyeYjBjSCS90QjsFDT3oDLSK6yrYtNmNKnBttjq2WsrKN64jAHQqtTNreh+g8jcCle GRj1PdvEZ5X6P6HH3EKLY4xPqKbSE4l+2ixJmCjfGHISSUHRoyjEsFBGJGhLV2J8hRMd 40AGHomjX4zd/+1q5rx/C9FrxI198syW/tjNFeAuug+8O8q+D5ben1/kPGjRx/gwISgD VDibYtJDDUF5At0xTSWLg0H64DbZF8fEjvPnxuDzc0V7tusKPACM82PR7cB1s/R3OF2n xeO1iX/HbALxAi0cmBin17Bu4AUpUOEqmaIc2u2hbBDwTMg+wbHuvFBMgMCb5eC3Buq7 bbKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pWpb99znXW/wwUK6jsz+nxy8SwKlRv7VVvwNtWgOIXU=; b=si1ftFKKfuk9KqldrjvVw3GHdc4UA4Q4aWfNnrIMBYcPICj/00aeku7oCt3JzMpwWp LPgVFjyV5D/zQXOMr7j0v+ugqcW2CXvq28tlKYJJZBHf34wp3vwLBUT1oeerevluHbZy UnF55Id5Jh8EW61exTRhTIyg2+qdJE1IznOswuTO4iEIHArj04mtIPVppKbKowhz8QkM jAX9rNhVZt+QI5/1yHvasGsBHD5+EqCnqQW5z+Hj8PKXJY2VneFufrqK1ccpK2XsN2Ww 4L0txa0z501EM0gDqGzF5OwzTap/H4iQ7P4tow0sOzth7cSx6IUwof46FW61ecDX/gZy Z/9w== X-Gm-Message-State: AN3rC/7/m5a52up1wEk3Km8UfZ20izRbIhhCXJKmhCOknEQfW4D1so/5 DvgsF3cO1fFzzQ== X-Received: by 10.223.148.132 with SMTP id 4mr7480717wrr.119.1493367882322; Fri, 28 Apr 2017 01:24:42 -0700 (PDT) Received: from amir-VirtualBox.lan (bzq-79-179-55-127.red.bezeqint.net. [79.179.55.127]) by smtp.gmail.com with ESMTPSA id e67sm637836wma.9.2017.04.28.01.24.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 28 Apr 2017 01:24:41 -0700 (PDT) From: Amir Goldstein To: Eryu Guan Cc: Miklos Szeredi , Xiong Zhou , linux-unionfs@vger.kernel.org, fstests@vger.kernel.org Subject: [PATCH v2 2/6] overlay/017: fix some comments Date: Fri, 28 Apr 2017 11:24:44 +0300 Message-Id: <1493367888-26550-3-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1493367888-26550-1-git-send-email-amir73il@gmail.com> References: <1493367888-26550-1-git-send-email-amir73il@gmail.com> Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Align all comments to the term 'constant inode numbers' and explain why hardlinks are excluded from this test. Signed-off-by: Amir Goldstein --- tests/overlay/017 | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/overlay/017 b/tests/overlay/017 index 7c1430d..e04690c 100755 --- a/tests/overlay/017 +++ b/tests/overlay/017 @@ -1,7 +1,7 @@ #! /bin/bash # FSQA Test No. 017 # -# Test unstable inode number +# Test constant inode numbers # # This simple test demonstrates a known issue with overlayfs: # - stat file A shows inode number X @@ -58,9 +58,8 @@ rm -f $seqres.full _scratch_mkfs >>$seqres.full 2>&1 # Create our test files. -# Not dealing with hardlinks here, because there is more to test -# then stable inode number. -# Hardlinks will get a test of their own. +# Not dealing with hardlinks here, when hardlinks are broken they +# should not preserve the inode number. lowerdir=$OVL_BASE_SCRATCH_MNT/$OVL_LOWER mkdir -p $lowerdir mkdir $lowerdir/dir