| Message ID | 1501493816-29678-1-git-send-email-yangx.jy@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jul 31, 2017 at 05:36:56PM +0800, Xiao Yang wrote: > On RHEL6.9GA, generic/097 fails for ext4 because _test_cycle_mount() > remount ext4 without the user_xattr option, so extended attributes > are not supported by ext4. > > On some old kernels, ext4 filesystem can not be mounted with acl and > user_xattr options by default. The following patch has enabled these > options by default: > 'ea6633369458("ext4: enable acls and user_xattr by default")' > > We add acl and user_xattr support in _test_mount_opts(), and it works > normally on all kernels. > > Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com> Thanks for the patch! But it exposes some bugs in config section handling, a section for xfs test could inherit TEST_FS_MOUNT_OPTS (and other variables like MOUNT_OPTIONS) from previous ext4 section, and xfs doesn't support acl mount option which results in a mount failure for TEST_DEV. I'll look into the config section bug first, and apply this patch after fixing that bug. This patch fixes a minor bug that only shows up on older kernels and only affects one test, so I think it's not urgent to fix. OTOH, I think config section is more widely used and affects more people. Thanks, Eryu > --- > common/config | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/common/config b/common/config > index 80598d0..4f7fba8 100644 > --- a/common/config > +++ b/common/config > @@ -335,6 +335,10 @@ _test_mount_opts() > glusterfs) > export TEST_FS_MOUNT_OPTS=$GLUSTERFS_MOUNT_OPTIONS > ;; > + ext2|ext3|ext4|ext4dev) > + # acls & xattrs aren't turned on by default on older ext$FOO > + export TEST_FS_MOUNT_OPTS="-o acl,user_xattr $EXT_MOUNT_OPTIONS" > + ;; > *) > ;; > esac > -- > 1.8.3.1 > > > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/common/config b/common/config index 80598d0..4f7fba8 100644 --- a/common/config +++ b/common/config @@ -335,6 +335,10 @@ _test_mount_opts() glusterfs) export TEST_FS_MOUNT_OPTS=$GLUSTERFS_MOUNT_OPTIONS ;; + ext2|ext3|ext4|ext4dev) + # acls & xattrs aren't turned on by default on older ext$FOO + export TEST_FS_MOUNT_OPTS="-o acl,user_xattr $EXT_MOUNT_OPTIONS" + ;; *) ;; esac
On RHEL6.9GA, generic/097 fails for ext4 because _test_cycle_mount() remount ext4 without the user_xattr option, so extended attributes are not supported by ext4. On some old kernels, ext4 filesystem can not be mounted with acl and user_xattr options by default. The following patch has enabled these options by default: 'ea6633369458("ext4: enable acls and user_xattr by default")' We add acl and user_xattr support in _test_mount_opts(), and it works normally on all kernels. Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com> --- common/config | 4 ++++ 1 file changed, 4 insertions(+)