| Message ID | 1503503357-26234-4-git-send-email-amir73il@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Aug 23, 2017 at 6:49 PM, Amir Goldstein <amir73il@gmail.com> wrote: > Not sure why, but with initstate()/setstate(), sfx generates > same events regadless of the input seed argument. > > Change to use srandom() to fix the problem. > > Add pid to auto random seed, so parallel fsx executions with auto > seed will use different seed values. > > At this time there are 6 tests that use sfx, out of which: > 2 use -S 0 as seed (gettime()) - generic/{075,112} > 2 do not specify seed (default = 1) - generic/{091,263} > 1 uses explicit constant seed - generic/127 > 1 uses explicit $RANDOM seed - generic/231 > > This change affects all those tests. > The tests that intended to randomize the seed will now really > randomize the seed. > The tests that intended to use a constant seed will still use > a constant seed, but resulting event sequence will be different > than before this change. > > Signed-off-by: Amir Goldstein <amir73il@gmail.com> Eryu, While the rest of the series make take longer time to land, I think you should consider applying this patch, or at least test how it affects test results on your test systems. Please let me know if you observe the same behavior as I do (you can use fsx -d to output all events to stdout) I wonder what is your opinion of randomized seed vs. constant seed in xfstest... anyway, the tests 075,112,231 seem to have been using effectively constant seed up to now, not as author intended. Cheers, Amir. > --- > ltp/fsx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/ltp/fsx.c b/ltp/fsx.c > index 3713bbe..572df75 100644 > --- a/ltp/fsx.c > +++ b/ltp/fsx.c > @@ -116,7 +116,6 @@ int fd; /* fd for our test file */ > blksize_t block_size = 0; > off_t file_size = 0; > off_t biggest = 0; > -char state[256]; > unsigned long testcalls = 0; /* calls to function "test" */ > > unsigned long simulatedopcount = 0; /* -b flag */ > @@ -1909,8 +1908,10 @@ main(int argc, char **argv) > break; > case 'S': > seed = getnum(optarg, &endp); > - if (seed == 0) > + if (seed == 0) { > seed = time(0) % 10000; > + seed += (int)getpid(); > + } > if (!quiet) > fprintf(stdout, "Seed set to %d\n", seed); > if (seed < 0) > @@ -1948,8 +1949,7 @@ main(int argc, char **argv) > signal(SIGUSR1, cleanup); > signal(SIGUSR2, cleanup); > > - initstate(seed, state, 256); > - setstate(state); > + srandom(seed); > fd = open(fname, > O_RDWR|(lite ? 0 : O_CREAT|O_TRUNC)|o_direct, 0666); > if (fd < 0) { > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 25, 2017 at 12:19:07PM +0300, Amir Goldstein wrote: > On Wed, Aug 23, 2017 at 6:49 PM, Amir Goldstein <amir73il@gmail.com> wrote: > > Not sure why, but with initstate()/setstate(), sfx generates > > same events regadless of the input seed argument. > > > > Change to use srandom() to fix the problem. > > > > Add pid to auto random seed, so parallel fsx executions with auto > > seed will use different seed values. > > > > At this time there are 6 tests that use sfx, out of which: > > 2 use -S 0 as seed (gettime()) - generic/{075,112} > > 2 do not specify seed (default = 1) - generic/{091,263} > > 1 uses explicit constant seed - generic/127 > > 1 uses explicit $RANDOM seed - generic/231 > > > > This change affects all those tests. > > The tests that intended to randomize the seed will now really > > randomize the seed. > > The tests that intended to use a constant seed will still use > > a constant seed, but resulting event sequence will be different > > than before this change. > > > > Signed-off-by: Amir Goldstein <amir73il@gmail.com> > > Eryu, > > While the rest of the series make take longer time to land, > I think you should consider applying this patch, or at least test > how it affects test results on your test systems. Sorry I got to this so late.. and thanks a lot for all the work you've done for this log-write test! > > Please let me know if you observe the same behavior as I do > (you can use fsx -d to output all events to stdout) Yes, I saw the same symptom as you've observed, the operation sequences are always the same no matter what seed I fed to fsx, I'm testing on both RHEL6 and RHEL7 hosts. It's so weird that seed doesn't have any effect on initstate and setstate, I'm not sure why either.. But your patch does change fsx to random mode. > > I wonder what is your opinion of randomized seed vs. constant > seed in xfstest... anyway, the tests 075,112,231 seem to have > been using effectively constant seed up to now, not as author > intended. I agree with Josef here, be as random as possible and print out the seed for debug purpose. So I think this patch is fine. I tested the affected tests a few times and they went on well. Thanks! Eryu -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/ltp/fsx.c b/ltp/fsx.c index 3713bbe..572df75 100644 --- a/ltp/fsx.c +++ b/ltp/fsx.c @@ -116,7 +116,6 @@ int fd; /* fd for our test file */ blksize_t block_size = 0; off_t file_size = 0; off_t biggest = 0; -char state[256]; unsigned long testcalls = 0; /* calls to function "test" */ unsigned long simulatedopcount = 0; /* -b flag */ @@ -1909,8 +1908,10 @@ main(int argc, char **argv) break; case 'S': seed = getnum(optarg, &endp); - if (seed == 0) + if (seed == 0) { seed = time(0) % 10000; + seed += (int)getpid(); + } if (!quiet) fprintf(stdout, "Seed set to %d\n", seed); if (seed < 0) @@ -1948,8 +1949,7 @@ main(int argc, char **argv) signal(SIGUSR1, cleanup); signal(SIGUSR2, cleanup); - initstate(seed, state, 256); - setstate(state); + srandom(seed); fd = open(fname, O_RDWR|(lite ? 0 : O_CREAT|O_TRUNC)|o_direct, 0666); if (fd < 0) {
Not sure why, but with initstate()/setstate(), sfx generates same events regadless of the input seed argument. Change to use srandom() to fix the problem. Add pid to auto random seed, so parallel fsx executions with auto seed will use different seed values. At this time there are 6 tests that use sfx, out of which: 2 use -S 0 as seed (gettime()) - generic/{075,112} 2 do not specify seed (default = 1) - generic/{091,263} 1 uses explicit constant seed - generic/127 1 uses explicit $RANDOM seed - generic/231 This change affects all those tests. The tests that intended to randomize the seed will now really randomize the seed. The tests that intended to use a constant seed will still use a constant seed, but resulting event sequence will be different than before this change. Signed-off-by: Amir Goldstein <amir73il@gmail.com> --- ltp/fsx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)