From patchwork Tue Sep 19 11:39:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 9958711 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5B248601E9 for ; Tue, 19 Sep 2017 11:39:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 52AB428D72 for ; Tue, 19 Sep 2017 11:39:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4709A28E15; Tue, 19 Sep 2017 11:39:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F189228D72 for ; Tue, 19 Sep 2017 11:39:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751476AbdISLjQ (ORCPT ); Tue, 19 Sep 2017 07:39:16 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36295 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbdISLjP (ORCPT ); Tue, 19 Sep 2017 07:39:15 -0400 Received: by mail-wm0-f66.google.com with SMTP id r136so3603143wmf.3; Tue, 19 Sep 2017 04:39:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wvxXC4aaWWG3scsbFYfXHq3/kIn4aWV1OHojfb03uvU=; b=EJPWpQQPhRrRXmzXTr59H+Tw7SmKXuV4HIEIxcdQpjpUDUb4cM9OLhwY9YnnxEiZHu E7WqFZFPtTpJUu6prNqfdsBimG0EK1avHdRfQoRszqtqPR50vHwI2zG8xPm7vT2xSNSR pG1jMFaIl9Vmc5DAdSHJ+Bq02lB6RX8tp7q73czlZiTfFzSLP4Javi1/1lXRtLmr5qcP ofSstOI+Lcp51INOljuQicehArkcrBQOV8G2E7r2D5qOnp35PiNBQCKUOXioW25G6ldg wct5RbQCNb3/Nx8BpZROxndu2AYNIGhLHwCmA5t86lp5NJl5ZPodMYFWzT2UhxgvdJwt tgHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wvxXC4aaWWG3scsbFYfXHq3/kIn4aWV1OHojfb03uvU=; b=CvYmO3+alHW2NE0ziczEXCM7su2AX2LAWyNDJ9Ei4BX4db0vM38mU3Vslx9FDZT517 J3ONH03kO5Ecdr5cVMHBvxHFHJK/D6PoIV/Bh5bGdU1Zyqj8WrSbGrWDH0FcVqi/7I5o /ZG9oYGp1ULFIffsx6J+gL+wOlRDxJWRIgd/hhtlbbG/S+ZezUzGJXjZklDAeCE2mWt4 +OfqEupJ/zV/i0dzLXgMUhr/PNGKoFbkDNvWvqO1EFcU0RFj3HUf3D334Jb2KUNLatdb Rzf5fMRDkHcar5/go7KjCM4oUYNroeE8ut9XdiahHGAQ/SQPeURbLwY2tdNTsjE3YdAP R/Ew== X-Gm-Message-State: AHPjjUiebUcOq6sPfmCzDCTirMAUTnkMl1hfDzf74i/vk208F39N0SE+ E9lnxx/cUjbXNFFDZxToak0= X-Google-Smtp-Source: AOwi7QCbxwm14CH52gQmaTeD1UkvUXwIOcr6BpAjAQxOMwHj5I5jiDUgAMA+1CZLEys46odHzFe6Cg== X-Received: by 10.28.218.146 with SMTP id r140mr780729wmg.14.1505821154439; Tue, 19 Sep 2017 04:39:14 -0700 (PDT) Received: from localhost.localdomain (bzq-166-168-31-246.red.bezeqint.net. [31.168.166.246]) by smtp.gmail.com with ESMTPSA id o59sm6659350wrc.45.2017.09.19.04.39.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Sep 2017 04:39:13 -0700 (PDT) From: Amir Goldstein To: Eryu Guan Cc: Miklos Szeredi , linux-unionfs@vger.kernel.org, fstests@vger.kernel.org Subject: [PATCH 1/2] overlay/014: correct comment relating to workdir reuse Date: Tue, 19 Sep 2017 14:39:43 +0300 Message-Id: <1505821184-3913-2-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505821184-3913-1-git-send-email-amir73il@gmail.com> References: <1505821184-3913-1-git-send-email-amir73il@gmail.com> Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Clarification: EBUSY is what you get when trying to use the same upperdir/workdir with two different *concurent* overlayfs mounts. The EBUSY case is independent of the inodes index feature. This is not the case in this test, but rather the case of trying to reuse the same workdir with different upper dirs on *subsequent* overlayfs mounts. Signed-off-by: Amir Goldstein --- tests/overlay/014 | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/overlay/014 b/tests/overlay/014 index f228b15..cd76835 100755 --- a/tests/overlay/014 +++ b/tests/overlay/014 @@ -63,10 +63,9 @@ lowerdir1=$OVL_BASE_SCRATCH_MNT/lower1 lowerdir2=$OVL_BASE_SCRATCH_MNT/lower2 upperdir=$OVL_BASE_SCRATCH_MNT/upper workdir=$OVL_BASE_SCRATCH_MNT/workdir -# When overlay inode index feature is enabled, using an upper layer path and/or -# a workdir path that are already used by another overlay mount is not allowed -# and will fail with EBUSY, so create another workdir for the second overlay -# mount +# When overlay inode index feature is enabled, a workdir cannot be reused +# with a different upperdir. workdir2 in this test is used as the workdir +# when lowerdir2 is used as the upperdir. workdir2=$OVL_BASE_SCRATCH_MNT/workdir2 mkdir -p $lowerdir1 $lowerdir2 $upperdir $workdir $workdir2 mkdir -p $lowerdir1/testdir/d