From patchwork Tue Nov 28 16:42:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 10080773 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2B85A6056F for ; Tue, 28 Nov 2017 16:42:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E74629365 for ; Tue, 28 Nov 2017 16:42:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 23973294B7; Tue, 28 Nov 2017 16:42:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8EE6129365 for ; Tue, 28 Nov 2017 16:42:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932093AbdK1QmG (ORCPT ); Tue, 28 Nov 2017 11:42:06 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:46139 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932071AbdK1QmE (ORCPT ); Tue, 28 Nov 2017 11:42:04 -0500 Received: by mail-wm0-f65.google.com with SMTP id r78so777046wme.5; Tue, 28 Nov 2017 08:42:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RdmAC3x7aK8WsuQIkmjGdpkeM6EZJoo4O0kWu4cf5Kw=; b=ejMeoyAHyePF9UjuORCIJTNG0DSoukMXZNcXdRso34/t5Xn4YL+Hgv4h0R43T5f9lu CD0Uj4RPI+DSIkFFmxxD1eHO6uzKxSVJoCnP/dVspD06jDHAYpD7JEVkg3gLyIN3HADm /3gv5qeUZEMq4AHzdGlF2oFZjvjGNi17pWX2a1iiKgBqoahUSslTlpt0duMpjtegY7Oo a/deOzqVmTjdjJBNEkRXfzcRFKEab7BhQvQbXwMIysIwa87pyHEBDOkBN9aS/e1Ml889 Qw8eaaJweyuD4rv5FHmceMvXiZZvtYJzq18PNxF0q7l0IEc2FOqrWhXAHkeck7+ccv7U vcnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RdmAC3x7aK8WsuQIkmjGdpkeM6EZJoo4O0kWu4cf5Kw=; b=dg1BLOj/p1pN2wcQyJCJb++5F2M1hB8hK60Uv6KTvK0udXG6r5kkYH0PbfI0TjNl9s YsTQrnjbdme9nu7J2bQ0GJR82h7FV3u+DIJTC2qbdnlzLMtVhQpoGtsW6niGVwF3EaTK bYANYc3/GoqI9qO37xwuJYMqH0Z3nLkLgxKCtVKf2SBeujHLTXyf/OW6vAV1imrcjUZ5 noWWgsTvt4tMtXhfS27q2ZndlOI1X9NwutanlORpcCvq7XrWhW4cVqrK5IxH+buXO41M RjyQ/Q7lAtL69xYYw7KOI1XDRiz1bs1d2RfoP+ZOx2PONzOYGjRY1h22Xz5uMgToG+VX +QBg== X-Gm-Message-State: AJaThX61lv2CDllWUx1C0YLxtnQJl4GHIx0mW27o36Pk8Uo8OtPO1NW+ +Fk1GMgnZWF0pUmClXJWBYM= X-Google-Smtp-Source: AGs4zMbjTQHz/h7VZH/87XJrVD9smTRV52ZC8EVXBOoUv/e7OFQ80z5mOqX2fpPXNWqldjHiui5HJg== X-Received: by 10.28.63.141 with SMTP id m135mr200062wma.72.1511887323004; Tue, 28 Nov 2017 08:42:03 -0800 (PST) Received: from localhost.localdomain (bzq-166-168-31-246.red.bezeqint.net. [31.168.166.246]) by smtp.gmail.com with ESMTPSA id r14sm70183446wrb.43.2017.11.28.08.42.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Nov 2017 08:42:02 -0800 (PST) From: Amir Goldstein To: Eryu Guan Cc: Miklos Szeredi , Vivek Goyal , linux-unionfs@vger.kernel.org, fstests@vger.kernel.org Subject: [PATCH 3/3] overlay/042: remove wrong check for empty index Date: Tue, 28 Nov 2017 18:42:02 +0200 Message-Id: <1511887322-29254-4-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1511887322-29254-1-git-send-email-amir73il@gmail.com> References: <1511887322-29254-1-git-send-email-amir73il@gmail.com> Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The check for empty index in this test was wrongly copied from test overlay/034. In test overlay/034 lower file starts as a hardlink, so nlink accounting is done from the first copy up and index can be cleaned on last upper hardlink unlink. In this test, lower starts as non-hardlink, so first copy up does not perform nlink accounting and therefore, union nlink count does not drop to 0 at the end of the test and the index is not expected to be cleaned. Signed-off-by: Amir Goldstein --- tests/overlay/042 | 4 ---- 1 file changed, 4 deletions(-) diff --git a/tests/overlay/042 b/tests/overlay/042 index dae5198..8967ff3 100755 --- a/tests/overlay/042 +++ b/tests/overlay/042 @@ -129,10 +129,6 @@ rm $SCRATCH_MNT/2 rm $SCRATCH_MNT/3 rm $SCRATCH_MNT/4 -# Verify that orphan index is cleaned on mount -_scratch_cycle_mount index=on -ls $OVL_BASE_SCRATCH_MNT/$OVL_WORK/index - echo "Silence is golden" status=0 exit