From patchwork Fri Jan 19 05:38:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Yang X-Patchwork-Id: 10174607 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 99E1060386 for ; Fri, 19 Jan 2018 05:46:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B286285FE for ; Fri, 19 Jan 2018 05:46:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7F6DB28602; Fri, 19 Jan 2018 05:46:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 156C2285FE for ; Fri, 19 Jan 2018 05:46:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751282AbeASFq4 (ORCPT ); Fri, 19 Jan 2018 00:46:56 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:50661 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751026AbeASFq4 (ORCPT ); Fri, 19 Jan 2018 00:46:56 -0500 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="35470625" Received: from bogon (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 19 Jan 2018 13:46:52 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id 25AE648AEA17; Fri, 19 Jan 2018 13:46:52 +0800 (CST) Received: from RHEL7.5Alpha (10.167.220.103) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 19 Jan 2018 13:46:52 +0800 From: xiao yang To: , CC: , , , xiao yang Subject: [PATCH v6 3/3] xfs: Regression test for invalid sb_logsunit Date: Fri, 19 Jan 2018 13:38:06 +0800 Message-ID: <1516340286-21331-2-git-send-email-yangx.jy@cn.fujitsu.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1516340286-21331-1-git-send-email-yangx.jy@cn.fujitsu.com> References: <20180118182915.GI5606@magnolia> <1516340286-21331-1-git-send-email-yangx.jy@cn.fujitsu.com> MIME-Version: 1.0 X-Originating-IP: [10.167.220.103] X-yoursite-MailScanner-ID: 25AE648AEA17.A9689 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: yangx.jy@cn.fujitsu.com Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If log stripe unit isn't a multiple of the fs blocksize and mounting, the invalid sb_logsunit leads to crash as soon as we try to write to the log. Signed-off-by: xiao yang --- tests/xfs/439 | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/439.out | 2 ++ tests/xfs/group | 1 + 3 files changed, 89 insertions(+) create mode 100755 tests/xfs/439 create mode 100644 tests/xfs/439.out diff --git a/tests/xfs/439 b/tests/xfs/439 new file mode 100755 index 0000000..dbf654a --- /dev/null +++ b/tests/xfs/439 @@ -0,0 +1,86 @@ +#! /bin/bash +# FS QA Test No. 439 +# +# Regression test for commit: +# 9c92ee2 ("xfs: validate sb_logsunit is a multiple of the fs blocksize") +# +# If log stripe unit isn't a multiple of the fs blocksize and mounting, +# the invalid sb_logsunit leads to crash as soon as we try to write to +# the log. +# +#----------------------------------------------------------------------- +# Copyright (c) 2018 FUJITSU. All Rights Reserved. +# Author: Xiao Yang +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=`basename "$0"` +seqres="$RESULT_DIR/$seq" +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + rm -rf $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_os Linux +_supported_fs xfs +_require_scratch +# We corrupt XFS on purpose, and check if assert failures would crash system. +_require_no_xfs_bug_on_assert + +rm -f "$seqres.full" + +# Format +_scratch_mkfs > $seqres.full 2>&1 || _fail "mkfs failed" + +# Set logsunit to a value which is not a multiple of the fs blocksize +blksz=$(_scratch_xfs_get_sb_field blocksize) +_scratch_xfs_set_sb_field logsunit $((blksz - 1)) >> $seqres.full 2>&1 + +# Check if logsunit is set correctly +lsunit=$(_scratch_xfs_get_sb_field logsunit) +[ $lsunit -ne $((blksz - 1)) ] && _notrun "failed to set sb_logsunit" + +# Mount and writing log may trigger a crash on buggy kernel +# The fix applied kernel refuses to mount, so a mount failure is +# expected +if _scratch_mount >> $seqres.full 2>&1; then + for i in $(seq 1 1000); do + echo > ${SCRATCH_MNT}/$i + done + _scratch_unmount +fi + +# We may trigger assert related WARNINGs if we corrupt log on a +# CONFIG_XFS_WARN or CONFIG_XFS_DEBUG (CONFIG_XFS_ASSERT_FATAL is +# disabled) build, so filter them. +_check_dmesg _filter_assert_dmesg + +echo "Silence is golden" + +# success, all done +status=0 +exit diff --git a/tests/xfs/439.out b/tests/xfs/439.out new file mode 100644 index 0000000..9712295 --- /dev/null +++ b/tests/xfs/439.out @@ -0,0 +1,2 @@ +QA output created by 439 +Silence is golden diff --git a/tests/xfs/group b/tests/xfs/group index 04a63b7..0b281a8 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -436,3 +436,4 @@ 436 auto quick clone fsr 437 auto quick other 438 auto quick quota dangerous +439 auto quick dangerous_fuzzers log