From patchwork Tue Jan 30 06:12:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 10191367 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B451860388 for ; Tue, 30 Jan 2018 06:11:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A42DE286E2 for ; Tue, 30 Jan 2018 06:11:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 98C45286E3; Tue, 30 Jan 2018 06:11:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 88CAA2891E for ; Tue, 30 Jan 2018 06:11:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752759AbeA3GLa (ORCPT ); Tue, 30 Jan 2018 01:11:30 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:55659 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752699AbeA3GL3 (ORCPT ); Tue, 30 Jan 2018 01:11:29 -0500 Received: by mail-wm0-f54.google.com with SMTP id 143so18689344wma.5; Mon, 29 Jan 2018 22:11:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MTTPBQqie5TB2K7E0qTOhLDpzBZqN3b4YFgzsKoiMT0=; b=F0OLC27o9yQifAMAp0HG9Kt9MzkIQNOgpiRep8xT1FSCbKvSpw+CCL6sxHhusVRxPs 42MAbKKwfUnGrS9cbHDwPqHL/qLtd9yHLTUkYCa95g5fNRE51HfzC5Cr4GRLJ12GqoTP 3Gz3NDoqQPxjMTr1hOHcq2hg05dSLmPvQ+wXf1EaZyEOMNpmByKUp5IhzDz3q9MHRkgl 26HeB6fzyPfRx6tA+aw8ErYgitKDC2Csh0S4FLsYMq+qAG03xcrwA7VR5v+j2XtlMMpo c8NLK6CvpizBs1qvMu8ElSRDLjM2xXjLCdy4g82y0pofZ0RgQO9S/7lCpyJ9ShysFS6w NVYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MTTPBQqie5TB2K7E0qTOhLDpzBZqN3b4YFgzsKoiMT0=; b=ZcvpsgmmViwvTysnvT8tQejMaq9Nzj0SMFJbo2KnD4EvfxM6CrEOIz895u2CQPa3Oa NbQ3LxGJ6GeAx2xRNH8Y3ojcWGvt4lxypQAjwa10WS4u0Mm+InskVn9O4XWlkbpMrfmd 6QTOWxJmAy5/vC/2j6DdA01L2X+dZaHaA8CKTyVgXncEt5Q/B/5zDoxfuZF8p94yGQbz Q6V8dJqVvq+iqTvwct/D1o6hBmnffjpU08UTdv8RO5yVAWtDJ4WQEFjzyxUs2/7t7X2+ mInTAIo46VyrSzaqDbMaRYbwz71fUAoDZR8ZEXZXklMmk0hdTuh5Zf8iRRcNWWg96z1d mwZw== X-Gm-Message-State: AKwxytc8MUFoGerAyyDzT1dxbkpjmuhduIgxpF6/rtss+SgdqiNQXmzl eahvOaLAPtSQMYSy3SINc4A= X-Google-Smtp-Source: AH8x224yKolpmvI9LwXRK2z0S+B6jGyBWbirwSMVjsq+ZZuWYf29lhfR2rvSYBTs3nzCkgFYGUne8w== X-Received: by 10.28.24.193 with SMTP id 184mr18814248wmy.144.1517292687558; Mon, 29 Jan 2018 22:11:27 -0800 (PST) Received: from localhost.localdomain ([141.226.172.80]) by smtp.gmail.com with ESMTPSA id 62sm11384075wrg.57.2018.01.29.22.11.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 29 Jan 2018 22:11:27 -0800 (PST) From: Amir Goldstein To: Eryu Guan Cc: Miklos Szeredi , linux-unionfs@vger.kernel.org, fstests@vger.kernel.org Subject: [PATCH v4 5/5] overlay: test encode/decode of non-samefs overlay file handles with renames Date: Tue, 30 Jan 2018 08:12:22 +0200 Message-Id: <1517292742-15624-6-git-send-email-amir73il@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517292742-15624-1-git-send-email-amir73il@gmail.com> References: <1517292742-15624-1-git-send-email-amir73il@gmail.com> Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This is a variant of overlay file handles with renames test for an overlayfs that is composed of multiple lower layers not on the same underlying fs. Signed-off-by: Amir Goldstein --- tests/overlay/053 | 200 ++++++++++++++++++++++++++++++++++++++++++++++++++ tests/overlay/053.out | 22 ++++++ tests/overlay/group | 1 + 3 files changed, 223 insertions(+) create mode 100755 tests/overlay/053 create mode 100644 tests/overlay/053.out diff --git a/tests/overlay/053 b/tests/overlay/053 new file mode 100755 index 0000000..d4fdcde --- /dev/null +++ b/tests/overlay/053 @@ -0,0 +1,200 @@ +#! /bin/bash +# FS QA Test No. 053 +# +# Test encode/decode of non-samefs overlay file handles with renames +# +# This is a variant of overlay file handles with renames test for an +# overlayfs that is composed of multiple lower layers not on the same +# underlying fs. +# +# - Check decode/read of file handles after rename of parent +# - Check decode/read of file handles after rename of grandparent +# - Check decode/read of file handles after move to new parent +# - Check encode/decode/read of file handles in non-upper overlay +# +# This test requires and enables overlayfs NFS export support and merge +# dir rename support (redirect_dir). +# NFS export support depends on and requires overlayfs index feature. +# +#----------------------------------------------------------------------- +# Copyright (C) 2018 CTERA Networks. All Rights Reserved. +# Author: Amir Goldstein +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* + # Cleanup overlay scratch mount that is holding base test mount + # to prevent _check_test_fs and _test_umount from failing before + # _check_scratch_fs _scratch_umount + $UMOUNT_PROG $SCRATCH_MNT 2>/dev/null +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here + +_supported_fs overlay +_supported_os Linux +_require_test +_require_scratch +_require_test_program "open_by_handle" +# We need to require all features together, because nfs_export cannot +# be enabled when index is disabled +_require_scratch_overlay_features index nfs_export redirect_dir + +# Lower is on test partition +lower=$OVL_BASE_TEST_DIR/$OVL_LOWER-$seq +# Upper/work are on scratch partition +middle=$OVL_BASE_SCRATCH_MNT/$OVL_LOWER +upper=$OVL_BASE_SCRATCH_MNT/$OVL_UPPER +work=$OVL_BASE_SCRATCH_MNT/$OVL_WORK + +NUMFILES=1 + +# Create test dir and empty test files +create_test_files() +{ + local dir=$1 + local opt=$2 + + mkdir -p $dir + $here/src/open_by_handle -cp $opt $dir $NUMFILES +} + +# Test encode/decode file handles on overlay mount +test_file_handles() +{ + local dir=$1 + shift + + echo test_file_handles $dir $* | _filter_scratch | \ + sed -e "s,$tmp\.,,g" + $here/src/open_by_handle $* $dir $NUMFILES +} + +# Re-create lower/middle/upper/work dirs +create_dirs() +{ + # Create lower dir on test partition + rm -rf $lower + mkdir $lower + + # Create middle/upper/work dirs on scratch partition + _scratch_mkfs +} + +# Mount an overlay on $SCRATCH_MNT with lower layer on test partition +# and middle and upper layer on scratch partition +mount_dirs() +{ + _overlay_scratch_mount_dirs $middle:$lower $upper $work \ + -o "index=on,nfs_export=on,redirect_dir=on" +} + +# Unmount the overlay without unmounting base fs +unmount_dirs() +{ + $UMOUNT_PROG $SCRATCH_MNT +} + +# Check non-stale file handles of lower/upper moved files +create_dirs +create_test_files $upper/uppertestdir -w +create_test_files $lower/lowertestdir -w +mkdir -p $lower/lowertestdir.lo $lower/lowertestdir.up $upper/uppertestdir.lo $upper/uppertestdir.up +mount_dirs +# Check encode/decode/read of lower/upper file handles after move to new upper testdir +test_file_handles $SCRATCH_MNT/uppertestdir -o $tmp.upper_file_handles +test_file_handles $SCRATCH_MNT/lowertestdir -o $tmp.lower_file_handles +mv $SCRATCH_MNT/uppertestdir/* $SCRATCH_MNT/uppertestdir.up/ +mv $SCRATCH_MNT/lowertestdir/* $SCRATCH_MNT/uppertestdir.lo/ +# Check open and read from stored file handles +test_file_handles $SCRATCH_MNT -r -i $tmp.upper_file_handles +test_file_handles $SCRATCH_MNT -r -i $tmp.lower_file_handles +# Check encode/decode/read of lower/upper file handles after move to new merge testdir +test_file_handles $SCRATCH_MNT/uppertestdir.up -o $tmp.upper_file_handles +test_file_handles $SCRATCH_MNT/uppertestdir.lo -o $tmp.lower_file_handles +mv $SCRATCH_MNT/uppertestdir.up/* $SCRATCH_MNT/lowertestdir.up/ +mv $SCRATCH_MNT/uppertestdir.lo/* $SCRATCH_MNT/lowertestdir.lo/ +# Check open and read from stored file handles +test_file_handles $SCRATCH_MNT -r -i $tmp.upper_file_handles +test_file_handles $SCRATCH_MNT -r -i $tmp.lower_file_handles +unmount_dirs + +# Check non-stale file handles of lower/upper renamed dirs +create_dirs +create_test_files $upper/uppertestdir -w +create_test_files $lower/lowertestdir -w +create_test_files $upper/uppertestdir/subdir -w +create_test_files $lower/lowertestdir/subdir -w +mount_dirs +# Check encode/decode/read of lower/upper file handles after rename of testdir +test_file_handles $SCRATCH_MNT/uppertestdir -p -o $tmp.upper_file_handles +test_file_handles $SCRATCH_MNT/lowertestdir -p -o $tmp.lower_file_handles +# Check encode/decode/read of lower/upper file handles after rename of testdir's parent +test_file_handles $SCRATCH_MNT/uppertestdir/subdir -p -o $tmp.upper_subdir_file_handles +test_file_handles $SCRATCH_MNT/lowertestdir/subdir -p -o $tmp.lower_subdir_file_handles +# Rename pure upper dir +mv $SCRATCH_MNT/uppertestdir $SCRATCH_MNT/uppertestdir.new/ +# Copy up lower dir, index and rename +mv $SCRATCH_MNT/lowertestdir $SCRATCH_MNT/lowertestdir.new/ +# Check open, read and readdir from stored file handles +# (testdir argument is the mount point and NOT the dir +# we are trying to open by stored file handle) +test_file_handles $SCRATCH_MNT -rp -i $tmp.upper_file_handles +test_file_handles $SCRATCH_MNT -rp -i $tmp.lower_file_handles +test_file_handles $SCRATCH_MNT -rp -i $tmp.upper_subdir_file_handles +test_file_handles $SCRATCH_MNT -rp -i $tmp.lower_subdir_file_handles +# Retry decoding lower subdir file handle when indexed testdir is in dcache +# (providing renamed testdir argument pins the indexed testdir to dcache) +test_file_handles $SCRATCH_MNT/lowertestdir.new -rp -i $tmp.lower_subdir_file_handles +unmount_dirs + +# Check encode/decode/read of lower file handles on lower layers only r/o overlay. +# For non-upper overlay mount, nfs_export requires disabling redirect_dir. +$MOUNT_PROG -t overlay $OVL_BASE_SCRATCH_MNT $SCRATCH_MNT \ + -o ro,redirect_dir=nofollow,nfs_export=on,lowerdir=$middle:$lower +test_file_handles $SCRATCH_MNT/lowertestdir -rp +test_file_handles $SCRATCH_MNT/lowertestdir/subdir -rp +unmount_dirs + +# Check encode/decode/read of lower file handles on lower layers only r/o overlay +# with non-indexed redirects from top lower layer to bottom lower layer. +# Overlay lookup cannot follow the redirect from $upper/lowertestdir.new to +# $lower/lowertestdir. Instead, we mount an overlay subtree rooted at these +# directories. +$MOUNT_PROG -t overlay $OVL_BASE_SCRATCH_MNT $SCRATCH_MNT \ + -o ro,redirect_dir=nofollow,nfs_export=on,lowerdir=$upper/lowertestdir.new:$lower/lowertestdir +test_file_handles $SCRATCH_MNT -r +test_file_handles $SCRATCH_MNT/subdir -rp +unmount_dirs + +status=0 +exit diff --git a/tests/overlay/053.out b/tests/overlay/053.out new file mode 100644 index 0000000..c6f9de0 --- /dev/null +++ b/tests/overlay/053.out @@ -0,0 +1,22 @@ +QA output created by 053 +test_file_handles SCRATCH_MNT/uppertestdir -o upper_file_handles +test_file_handles SCRATCH_MNT/lowertestdir -o lower_file_handles +test_file_handles SCRATCH_MNT -r -i upper_file_handles +test_file_handles SCRATCH_MNT -r -i lower_file_handles +test_file_handles SCRATCH_MNT/uppertestdir.up -o upper_file_handles +test_file_handles SCRATCH_MNT/uppertestdir.lo -o lower_file_handles +test_file_handles SCRATCH_MNT -r -i upper_file_handles +test_file_handles SCRATCH_MNT -r -i lower_file_handles +test_file_handles SCRATCH_MNT/uppertestdir -p -o upper_file_handles +test_file_handles SCRATCH_MNT/lowertestdir -p -o lower_file_handles +test_file_handles SCRATCH_MNT/uppertestdir/subdir -p -o upper_subdir_file_handles +test_file_handles SCRATCH_MNT/lowertestdir/subdir -p -o lower_subdir_file_handles +test_file_handles SCRATCH_MNT -rp -i upper_file_handles +test_file_handles SCRATCH_MNT -rp -i lower_file_handles +test_file_handles SCRATCH_MNT -rp -i upper_subdir_file_handles +test_file_handles SCRATCH_MNT -rp -i lower_subdir_file_handles +test_file_handles SCRATCH_MNT/lowertestdir.new -rp -i lower_subdir_file_handles +test_file_handles SCRATCH_MNT/lowertestdir -rp +test_file_handles SCRATCH_MNT/lowertestdir/subdir -rp +test_file_handles SCRATCH_MNT -r +test_file_handles SCRATCH_MNT/subdir -rp diff --git a/tests/overlay/group b/tests/overlay/group index 07dcf52..ec0b711 100644 --- a/tests/overlay/group +++ b/tests/overlay/group @@ -53,3 +53,4 @@ 050 auto quick copyup hardlink exportfs 051 auto quick copyup hardlink exportfs nonsamefs 052 auto quick copyup redirect exportfs +053 auto quick copyup redirect exportfs nonsamefs