diff mbox

xfs/298: cd to / instead of ~

Message ID 151e7c9999ff4680ee8456a75c5a527dede906fe.1479256416.git.osandov@fb.com (mailing list archive)
State New, archived
Headers show

Commit Message

Omar Sandoval Nov. 16, 2016, 12:34 a.m. UTC 
From: Omar Sandoval <osandov@fb.com>

In our kernel testing infrastructure, "$HOME" isn't defined. Everywhere
else in xfstests does `cd /` instead, so let's just do that.

Signed-off-by: Omar Sandoval <osandov@fb.com>
---
 tests/xfs/298 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zorro Lang Nov. 16, 2016, 3:51 a.m. UTC | #1 
On Tue, Nov 15, 2016 at 04:34:01PM -0800, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> 
> In our kernel testing infrastructure, "$HOME" isn't defined. Everywhere
> else in xfstests does `cd /` instead, so let's just do that.
> 
> Signed-off-by: Omar Sandoval <osandov@fb.com>
> ---
>  tests/xfs/298 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/298 b/tests/xfs/298
> index 7702526..26fb5c8 100755
> --- a/tests/xfs/298
> +++ b/tests/xfs/298
> @@ -80,7 +80,7 @@ while [ $SIZE -lt 1024 ];do
>  # remove the symlink - make sure ifree removes the remote symlink.
>  	rm $SYMLINK_FILE
>  # umount and check the number of extents on the inode. Should be 0.
> -	cd
> +	cd /

How about do this:
  while
    ...
    pushd $SCRATCH_MNT >/dev/null
    ...
    ...
    popd >/dev/null
    ...
  done

Thanks,
Zorro

>  	_scratch_unmount >/dev/null 2>&1
>  	_scratch_xfs_db  -c "inode $inode" -c "p core.nextents"
>  
> -- 
> 2.10.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tests/xfs/298 b/tests/xfs/298
index 7702526..26fb5c8 100755
--- a/tests/xfs/298
+++ b/tests/xfs/298
@@ -80,7 +80,7 @@  while [ $SIZE -lt 1024 ];do
 # remove the symlink - make sure ifree removes the remote symlink.
 	rm $SYMLINK_FILE
 # umount and check the number of extents on the inode. Should be 0.
-	cd
+	cd /
 	_scratch_unmount >/dev/null 2>&1
 	_scratch_xfs_db  -c "inode $inode" -c "p core.nextents"