diff mbox series

[10/13] check: use generated group files

Message ID 162317281679.653489.1178774292862746443.stgit@locust (mailing list archive)
State New, archived
Headers show
Series fstests: move test group lists into test files | expand

Commit Message

Darrick J. Wong June 8, 2021, 5:20 p.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

Convert the ./check script to use the automatically generated group list
membership files, as the transition is now complete.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 check |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Chandan Babu R June 11, 2021, 7:49 a.m. UTC | #1 
On 08 Jun 2021 at 22:50, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Convert the ./check script to use the automatically generated group list
> membership files, as the transition is now complete.
>

Looks good.

Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>

> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>  check |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
>
> diff --git a/check b/check
> index ba192042..3dab7630 100755
> --- a/check
> +++ b/check
> @@ -124,9 +124,9 @@ get_sub_group_list()
>  	local d=$1
>  	local grp=$2
>  
> -	test -s "$SRC_DIR/$d/group" || return 1
> +	test -s "$SRC_DIR/$d/group.list" || return 1
>  
> -	local grpl=$(sed -n < $SRC_DIR/$d/group \
> +	local grpl=$(sed -n < $SRC_DIR/$d/group.list \
>  		-e 's/#.*//' \
>  		-e 's/$/ /' \
>  		-e "s;^\($VALID_TEST_NAME\).* $grp .*;$SRC_DIR/$d/\1;p")
> @@ -384,7 +384,7 @@ if $have_test_arg; then
>  				test_dir=`dirname $t`
>  				test_dir=${test_dir#$SRC_DIR/*}
>  				test_name=`basename $t`
> -				group_file=$SRC_DIR/$test_dir/group
> +				group_file=$SRC_DIR/$test_dir/group.list
>  
>  				if egrep -q "^$test_name" $group_file; then
>  					# in group file ... OK
Allison Henderson June 14, 2021, 7:39 p.m. UTC | #2 
On 6/8/21 10:20 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Convert the ./check script to use the automatically generated group list
> membership files, as the transition is now complete.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Looks ok
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>

> ---
>   check |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> 
> diff --git a/check b/check
> index ba192042..3dab7630 100755
> --- a/check
> +++ b/check
> @@ -124,9 +124,9 @@ get_sub_group_list()
>   	local d=$1
>   	local grp=$2
>   
> -	test -s "$SRC_DIR/$d/group" || return 1
> +	test -s "$SRC_DIR/$d/group.list" || return 1
>   
> -	local grpl=$(sed -n < $SRC_DIR/$d/group \
> +	local grpl=$(sed -n < $SRC_DIR/$d/group.list \
>   		-e 's/#.*//' \
>   		-e 's/$/ /' \
>   		-e "s;^\($VALID_TEST_NAME\).* $grp .*;$SRC_DIR/$d/\1;p")
> @@ -384,7 +384,7 @@ if $have_test_arg; then
>   				test_dir=`dirname $t`
>   				test_dir=${test_dir#$SRC_DIR/*}
>   				test_name=`basename $t`
> -				group_file=$SRC_DIR/$test_dir/group
> +				group_file=$SRC_DIR/$test_dir/group.list
>   
>   				if egrep -q "^$test_name" $group_file; then
>   					# in group file ... OK
>
diff mbox series

Patch

diff --git a/check b/check
index ba192042..3dab7630 100755
--- a/check
+++ b/check
@@ -124,9 +124,9 @@  get_sub_group_list()
 	local d=$1
 	local grp=$2
 
-	test -s "$SRC_DIR/$d/group" || return 1
+	test -s "$SRC_DIR/$d/group.list" || return 1
 
-	local grpl=$(sed -n < $SRC_DIR/$d/group \
+	local grpl=$(sed -n < $SRC_DIR/$d/group.list \
 		-e 's/#.*//' \
 		-e 's/$/ /' \
 		-e "s;^\($VALID_TEST_NAME\).* $grp .*;$SRC_DIR/$d/\1;p")
@@ -384,7 +384,7 @@  if $have_test_arg; then
 				test_dir=`dirname $t`
 				test_dir=${test_dir#$SRC_DIR/*}
 				test_name=`basename $t`
-				group_file=$SRC_DIR/$test_dir/group
+				group_file=$SRC_DIR/$test_dir/group.list
 
 				if egrep -q "^$test_name" $group_file; then
 					# in group file ... OK