diff mbox series

ext4/051: correct kernel commit

Message ID 1636514473-2107-1-git-send-email-xuyang2018.jy@fujitsu.com (mailing list archive)
State New, archived
Headers show
Series ext4/051: correct kernel commit | expand

Commit Message

Yang Xu (Fujitsu) Nov. 10, 2021, 3:21 a.m. UTC
ext4/051 fails on my test machine, but I can't find commit in e2fsprogs
according to commit log that said it is a e2fsprog regression test.
Actually, it is a kernel regression test.
So remind user it is a kernel regression test and use correct fix kernel
commit[1].

[1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b2bbb92f

Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
 tests/ext4/051 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Boyang Xue Nov. 12, 2021, 11:45 p.m. UTC | #1
Hello Yang Xu,

I'm the author of the test ext4/051. Yes the original commit ID and
message is wrong, and I think you're correcting with the right commit.
Thanks for fixing it!

I was not aware of it but the original patch had been edited before
finally merged in mainline:
https://lore.kernel.org/all/20210812124737.21981-1-jack@suse.cz/

Thanks,
Boyang

On Wed, Nov 10, 2021 at 11:21 AM Yang Xu <xuyang2018.jy@fujitsu.com> wrote:
>
> ext4/051 fails on my test machine, but I can't find commit in e2fsprogs
> according to commit log that said it is a e2fsprog regression test.
> Actually, it is a kernel regression test.
> So remind user it is a kernel regression test and use correct fix kernel
> commit[1].
>
> [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b2bbb92f
>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
>  tests/ext4/051 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/ext4/051 b/tests/ext4/051
> index b4f56b08..d0e01465 100755
> --- a/tests/ext4/051
> +++ b/tests/ext4/051
> @@ -5,8 +5,8 @@
>  # FS QA Test No. 051
>  #
>  # Test that tune2fs doesn't fail after ext4 shutdown
> -# Regression test for commit:
> -# e905fbe3fd0f ext4: Fix tune2fs checksum failure for mounted filesystem
> +# Regression test for kernel commit:
> +# b2bbb92f7042 ext4: fix e2fsprogs checksum failure for mounted filesystem
>  #
>  . ./common/preamble
>  _begin_fstest auto rw quick
> --
> 2.23.0
>
diff mbox series

Patch

diff --git a/tests/ext4/051 b/tests/ext4/051
index b4f56b08..d0e01465 100755
--- a/tests/ext4/051
+++ b/tests/ext4/051
@@ -5,8 +5,8 @@ 
 # FS QA Test No. 051
 #
 # Test that tune2fs doesn't fail after ext4 shutdown
-# Regression test for commit:
-# e905fbe3fd0f ext4: Fix tune2fs checksum failure for mounted filesystem
+# Regression test for kernel commit:
+# b2bbb92f7042 ext4: fix e2fsprogs checksum failure for mounted filesystem
 #
 . ./common/preamble
 _begin_fstest auto rw quick