Message ID | 168609055958.2590724.15653702877825285667.stgit@frogsfrogsfrogs (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | fstests: random fixes for v2023.05.28 | expand |
On Tue, Jun 06, 2023 at 03:29:19PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > If this test fails after a certain number of writes, we should state > the exact number of writes so that we can coordinate with 155.full. > Instead, we state the pre-randomization number, which isn't all that > helpful. > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> Makes sense. Reviewed-by: Bill O'Donnell <bodonnel@redhat.com> > --- > tests/xfs/155 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > > diff --git a/tests/xfs/155 b/tests/xfs/155 > index 25cc84069c..302607b510 100755 > --- a/tests/xfs/155 > +++ b/tests/xfs/155 > @@ -63,11 +63,12 @@ done > > # If NEEDSREPAIR is still set on the filesystem, ensure that a full run > # cleans everything up. > +echo "Checking filesystem one last time after $allowed_writes writes." >> $seqres.full > if _check_scratch_xfs_features NEEDSREPAIR &> /dev/null; then > echo "Clearing NEEDSREPAIR" >> $seqres.full > _scratch_xfs_repair 2>> $seqres.full > _check_scratch_xfs_features NEEDSREPAIR > /dev/null && \ > - echo "Repair failed to clear NEEDSREPAIR on the $nr_writes writes test" > + echo "Repair failed to clear NEEDSREPAIR on the $allowed_writes writes test" > fi > > # success, all done >
diff --git a/tests/xfs/155 b/tests/xfs/155 index 25cc84069c..302607b510 100755 --- a/tests/xfs/155 +++ b/tests/xfs/155 @@ -63,11 +63,12 @@ done # If NEEDSREPAIR is still set on the filesystem, ensure that a full run # cleans everything up. +echo "Checking filesystem one last time after $allowed_writes writes." >> $seqres.full if _check_scratch_xfs_features NEEDSREPAIR &> /dev/null; then echo "Clearing NEEDSREPAIR" >> $seqres.full _scratch_xfs_repair 2>> $seqres.full _check_scratch_xfs_features NEEDSREPAIR > /dev/null && \ - echo "Repair failed to clear NEEDSREPAIR on the $nr_writes writes test" + echo "Repair failed to clear NEEDSREPAIR on the $allowed_writes writes test" fi # success, all done