diff mbox series

[3/3] generic/735: skip this test if we cannot finsert at pos 1M

Message ID 170250688518.1363584.11932716959963736458.stgit@frogsfrogsfrogs (mailing list archive)
State New, archived
Headers show
Series fstests: random fixes for v2023.12.10 | expand

Commit Message

Darrick J. Wong Dec. 13, 2023, 10:34 p.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

Add a _require_congruent_file_oplen to screen out filesystem
configurations that can't start a finsert operation at file pos 1M
because the fs block size isn't congruent with 1048576.  For example,
xfs realtime with 28k rt extents.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/generic/735 |    1 +
 1 file changed, 1 insertion(+)

Comments

Christoph Hellwig Dec. 14, 2023, 4:45 a.m. UTC | #1 
On Wed, Dec 13, 2023 at 02:34:45PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Add a _require_congruent_file_oplen to screen out filesystem
> configurations that can't start a finsert operation at file pos 1M
> because the fs block size isn't congruent with 1048576.  For example,
> xfs realtime with 28k rt extents.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/tests/generic/735 b/tests/generic/735
index 44b454771d..75b23d5efc 100755
--- a/tests/generic/735
+++ b/tests/generic/735
@@ -25,6 +25,7 @@  dev_size=$((80 * 1024 * 1024))
 _scratch_mkfs_sized $dev_size >>$seqres.full 2>&1 || _fail "mkfs failed"
 
 _scratch_mount
+_require_congruent_file_oplen $SCRATCH_MNT 1048576	# finsert at 1M
 file_blksz="$(_get_file_block_size ${SCRATCH_MNT})"
 
 # Reserve 1M space