| Message ID | 170620924507.3283496.17636943697618850238.stgit@frogsfrogsfrogs (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/10] generic/256: constrain runtime with TIME_FACTOR | expand |
On 2024-01-25 11:06:35, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > The xfs_attr_shortform struct (with multiple flexarrays) was removed in > 6.8. Check the two surviving structures (the attr sf header and entry) > instead. > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > --- > tests/xfs/122.out | 2 ++ > 1 file changed, 2 insertions(+) > > > diff --git a/tests/xfs/122.out b/tests/xfs/122.out > index 89f7b735b0..067a0ec76b 100644 > --- a/tests/xfs/122.out > +++ b/tests/xfs/122.out > @@ -62,6 +62,8 @@ sizeof(struct xfs_agfl) = 36 > sizeof(struct xfs_attr3_leaf_hdr) = 80 > sizeof(struct xfs_attr3_leafblock) = 88 > sizeof(struct xfs_attr3_rmt_hdr) = 56 > +sizeof(struct xfs_attr_sf_entry) = 3 > +sizeof(struct xfs_attr_sf_hdr) = 4 > sizeof(struct xfs_attr_shortform) = 8 > sizeof(struct xfs_attrd_log_format) = 16 > sizeof(struct xfs_attri_log_format) = 40 > > LGTM Reviewed-by: Andrey Albershteyn <aalbersh@redhat.com>
On Thu, Jan 25, 2024 at 11:06:35AM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > The xfs_attr_shortform struct (with multiple flexarrays) was removed in > 6.8. Check the two surviving structures (the attr sf header and entry) > instead. Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de> Although we really need to just kill this test. Let me resubmit my series to do the checking in libxfs using the newly shared kernel code.
diff --git a/tests/xfs/122.out b/tests/xfs/122.out index 89f7b735b0..067a0ec76b 100644 --- a/tests/xfs/122.out +++ b/tests/xfs/122.out @@ -62,6 +62,8 @@ sizeof(struct xfs_agfl) = 36 sizeof(struct xfs_attr3_leaf_hdr) = 80 sizeof(struct xfs_attr3_leafblock) = 88 sizeof(struct xfs_attr3_rmt_hdr) = 56 +sizeof(struct xfs_attr_sf_entry) = 3 +sizeof(struct xfs_attr_sf_hdr) = 4 sizeof(struct xfs_attr_shortform) = 8 sizeof(struct xfs_attrd_log_format) = 16 sizeof(struct xfs_attri_log_format) = 40