diff mbox series

[1/1] common/populate: fix bash syntax error in _fill_fs

Message ID 172780125692.3586386.8156040885377148056.stgit@frogsfrogsfrogs (mailing list archive)
State New, archived
Headers show
Series [1/1] common/populate: fix bash syntax error in _fill_fs | expand

Commit Message

Darrick J. Wong Oct. 1, 2024, 4:48 p.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

In bash, one does not set a variable by prepending the dollar sign to
the variable name.  Amazingly, this was copied verbatim from generic/256
in 2016 and hasn't been caught since its introduction in 2011. :(

Cc: allison.henderson@oracle.com
Fixes: 815015e9ee ("generic: make 17[1-4] work well when btrfs compression is enabled")
Fixes: b55fb0807c ("xfstests: Add ENOSPC Hole Punch Test")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 common/populate |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig Oct. 2, 2024, 5:44 a.m. UTC | #1 
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/common/populate b/common/populate
index 9fda19df06..88c8ba2b32 100644
--- a/common/populate
+++ b/common/populate
@@ -945,7 +945,7 @@  _fill_fs()
 	echo $testio | grep -q "Operation not supported" && use_falloc=0
 
 	if [ $file_size -lt $block_size ]; then
-		$file_size = $block_size
+		file_size=$block_size
 	fi
 
 	while [ $file_size -ge $block_size ]; do