| Message ID | 173870406473.546134.15374973350883945437.stgit@frogsfrogsfrogs (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/34] generic/476: fix fsstress process management | expand |
On Tue, Feb 04, 2025 at 01:28:34PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > Stop the fsx scrub stress loop if fsx returns a nonzero error code. > > Cc: <fstests@vger.kernel.org> # v2023.01.15 > Fixes: a2056ca8917bc8 ("fuzzy: enhance scrub stress testing to use fsx") > Signed-off-by: "Darrick J. Wong" <djwong@kernel.org> > --- > common/fuzzy | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) looks good. Reviewed-by: Dave Chinner <dchinner@redhat.com>
diff --git a/common/fuzzy b/common/fuzzy index 6d390d4efbd3da..9d5f01fb087033 100644 --- a/common/fuzzy +++ b/common/fuzzy @@ -942,6 +942,7 @@ __stress_scrub_fsx_loop() { local remount_period="$3" local stress_tgt="$4" # ignored local focus=(-q -X) # quiet, validate file contents + local res # As of November 2022, 2 million fsx ops should be enough to keep # any filesystem busy for a couple of hours. @@ -993,7 +994,9 @@ __stress_scrub_fsx_loop() { # Need to recheck running conditions if we cleared anything __stress_scrub_clean_scratch && continue $here/ltp/fsx $args >> $seqres.full - echo "fsx exits with $? at $(date)" >> $seqres.full + res=$? + echo "fsx exits with $res at $(date)" >> $seqres.full + test "$res" -ne 0 && break done rm -f "$runningfile" }