diff mbox series

[11/12] xfs/28[56],xfs/56[56]: add to the auto group

Message ID 173992587607.4078254.10572528213509901449.stgit@frogsfrogsfrogs (mailing list archive)
State New
Headers show
Series [01/12] misc: drop the dangerous label from xfs_scrub fsstress tests | expand

Commit Message

Darrick J. Wong Feb. 19, 2025, 12:53 a.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

Enable /some/ testing of online fsck for everybody by adding these two
fsstress tests and two fsx tests to the auto group.  At this time I
don't have any plans to do the same for the other scrub stress tests.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 tests/xfs/285 |    2 +-
 tests/xfs/286 |    2 +-
 tests/xfs/565 |    2 +-
 tests/xfs/566 |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

Comments

Christoph Hellwig Feb. 19, 2025, 6 a.m. UTC | #1 
On Tue, Feb 18, 2025 at 04:53:11PM -0800, Darrick J. Wong wrote:
> fsstress tests and two fsx tests to the auto group.  At this time I
> don't have any plans to do the same for the other scrub stress tests.

Can you explain why only these four?
Darrick J. Wong Feb. 19, 2025, 6:05 a.m. UTC | #2 
On Tue, Feb 18, 2025 at 10:00:57PM -0800, Christoph Hellwig wrote:
> On Tue, Feb 18, 2025 at 04:53:11PM -0800, Darrick J. Wong wrote:
> > fsstress tests and two fsx tests to the auto group.  At this time I
> > don't have any plans to do the same for the other scrub stress tests.
> 
> Can you explain why only these four?

The rest of the stress tests pick /one/ metadata type and race
scrub/repair of it against fsstress by invoking xfs_io repeatedly.
xfs/28[56] runs the whole xfs_scrub program repeatedly so we get to
exercise all of them in a single test.

(The more specific ones make it a lot easier to debug problems.)

--D
Christoph Hellwig Feb. 19, 2025, 6:08 a.m. UTC | #3 
On Tue, Feb 18, 2025 at 10:05:04PM -0800, Darrick J. Wong wrote:
> > Can you explain why only these four?
> 
> The rest of the stress tests pick /one/ metadata type and race
> scrub/repair of it against fsstress by invoking xfs_io repeatedly.
> xfs/28[56] runs the whole xfs_scrub program repeatedly so we get to
> exercise all of them in a single test.
> 
> (The more specific ones make it a lot easier to debug problems.)

Can you add this to the commit log?  With that:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Darrick J. Wong Feb. 19, 2025, 6:13 a.m. UTC | #4 
On Tue, Feb 18, 2025 at 10:08:06PM -0800, Christoph Hellwig wrote:
> On Tue, Feb 18, 2025 at 10:05:04PM -0800, Darrick J. Wong wrote:
> > > Can you explain why only these four?
> > 
> > The rest of the stress tests pick /one/ metadata type and race
> > scrub/repair of it against fsstress by invoking xfs_io repeatedly.
> > xfs/28[56] runs the whole xfs_scrub program repeatedly so we get to
> > exercise all of them in a single test.
> > 
> > (The more specific ones make it a lot easier to debug problems.)
> 
> Can you add this to the commit log?  With that:

Will do!

> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks!

--D
diff mbox series

Patch

diff --git a/tests/xfs/285 b/tests/xfs/285
index f08cb449b61ad4..205f8cdf943e47 100755
--- a/tests/xfs/285
+++ b/tests/xfs/285
@@ -8,7 +8,7 @@ 
 # or livelock.
 #
 . ./common/preamble
-_begin_fstest scrub fsstress_scrub
+_begin_fstest auto scrub fsstress_scrub
 
 _cleanup() {
 	cd /
diff --git a/tests/xfs/286 b/tests/xfs/286
index 046638296e04c6..abc4cafdb0992f 100755
--- a/tests/xfs/286
+++ b/tests/xfs/286
@@ -8,7 +8,7 @@ 
 # crash or livelock.
 #
 . ./common/preamble
-_begin_fstest online_repair fsstress_online_repair
+_begin_fstest auto online_repair fsstress_online_repair
 
 _cleanup() {
 	cd /
diff --git a/tests/xfs/565 b/tests/xfs/565
index 43185a253d4d71..d07706b3815b21 100755
--- a/tests/xfs/565
+++ b/tests/xfs/565
@@ -8,7 +8,7 @@ 
 # or livelock.
 #
 . ./common/preamble
-_begin_fstest scrub fsstress_scrub
+_begin_fstest auto scrub fsstress_scrub
 
 _cleanup() {
 	cd /
diff --git a/tests/xfs/566 b/tests/xfs/566
index 5398d1d0827ca2..2667e25f239559 100755
--- a/tests/xfs/566
+++ b/tests/xfs/566
@@ -8,7 +8,7 @@ 
 # crash or livelock.
 #
 . ./common/preamble
-_begin_fstest online_repair fsstress_online_repair
+_begin_fstest auto online_repair fsstress_online_repair
 
 _cleanup() {
 	cd /