diff mbox series

[10/12] common/populate: label newly created xfs filesystems

Message ID 173992588245.4078751.18091181818919832636.stgit@frogsfrogsfrogs (mailing list archive)
State New
Headers show
Series [01/12] various: fix finding metadata inode numbers when metadir is enabled | expand

Commit Message

Darrick J. Wong Feb. 19, 2025, 12:56 a.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

When we're creating fully populated filesystems, add an obviously weird
label to the filesystem images so that it's obvious that it's a test
filesystem.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 common/populate |    8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Christoph Hellwig Feb. 19, 2025, 6:06 a.m. UTC | #1 
On Tue, Feb 18, 2025 at 04:56:03PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> When we're creating fully populated filesystems, add an obviously weird
> label to the filesystem images so that it's obvious that it's a test
> filesystem.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/common/populate b/common/populate
index c907e04efd0ea9..7690f269df8e79 100644
--- a/common/populate
+++ b/common/populate
@@ -280,6 +280,10 @@  _scratch_xfs_populate() {
 		esac
 	done
 
+	# fill the fs label with obvious emoji because nobody uses them in prod
+	# and blkid throws a fit
+	_scratch_xfs_admin -L 'I❤