From patchwork Sun Dec 14 22:17:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Theodore Ts'o X-Patchwork-Id: 5489401 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3058CBEEA8 for ; Sun, 14 Dec 2014 22:17:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5BA53209FF for ; Sun, 14 Dec 2014 22:17:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B9A2209FD for ; Sun, 14 Dec 2014 22:17:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751164AbaLNWRP (ORCPT ); Sun, 14 Dec 2014 17:17:15 -0500 Received: from imap.thunk.org ([74.207.234.97]:55642 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbaLNWRP (ORCPT ); Sun, 14 Dec 2014 17:17:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=+h1HBVrwndVG28aU3ZHxRsEagq6YouiKKIAPrHCXRqE=; b=BTye7JONGJzWNs0WgYzavqQQkuOGAbt72knO3kDBLgVi2jKhfvSMNmi35FbypwEvRqWJqG5ofZlfgSixhfl6lNLVaoRwVH4plpqexvy9d5jUoBe5bp+GUt8F2VaXJiEaxx9TP7V9ylT6gYCJweEZDkIGrSY74LzLeMQCg2gqUr8=; Received: from root (helo=closure.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.80) (envelope-from ) id 1Y0HTV-00084v-Qn; Sun, 14 Dec 2014 22:17:13 +0000 Received: by closure.thunk.org (Postfix, from userid 15806) id 9D8E358055D; Sun, 14 Dec 2014 17:17:13 -0500 (EST) Date: Sun, 14 Dec 2014 17:17:13 -0500 From: Theodore Ts'o To: Eryu Guan Cc: fstests@vger.kernel.org Subject: Re: [PATCH v3] generic/299: various fixes Message-ID: <20141214221713.GQ29787@thunk.org> References: <1418295529-20565-1-git-send-email-eguan@redhat.com> <1418359401-8240-1-git-send-email-eguan@redhat.com> <20141214221221.GP29787@thunk.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20141214221221.GP29787@thunk.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sun, Dec 14, 2014 at 05:12:21PM -0500, Theodore Ts'o wrote: > I'm currently a testing a patch which uses "pgrep -f $XFS_IO_PROG" > instead, but I'm a bit surprised no once else noticed this, I guess > people aren't building their xfstests test kernels with DM_SNAPSHOP or > DM_VERITY configured (either of which will seleect DM_BUFIO)? Ah, right, this hasn't gone upstream yet; I had just pulled it in because I was seeing the problem with the umount hanging and killing my test runs. Anyway, Eryu, I'd suggest you resend your patch with the following change, which seems to fix things up for me. And with this patch included, feel free to add: Reviewed-by: Theodore Ts'o - Ted --- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/tests/generic/299 b/tests/generic/299 index e5de45b..9b99a66 100755 --- a/tests/generic/299 +++ b/tests/generic/299 @@ -138,7 +138,7 @@ _workout() done # Following like will check that pid is still run. # Once fio exit we can stop fallocate/truncate loop - pgrep fio > /dev/null 2>&1 || break + pgrep -f $XFS_IO_PROG > /dev/null 2>&1 || break done wait $pid }