From patchwork Tue May 5 00:51:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Chinner X-Patchwork-Id: 6330811 Return-Path: X-Original-To: patchwork-fstests@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 149A89F373 for ; Tue, 5 May 2015 00:51:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5754D202F0 for ; Tue, 5 May 2015 00:51:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 53615202DD for ; Tue, 5 May 2015 00:51:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbbEEAv0 (ORCPT ); Mon, 4 May 2015 20:51:26 -0400 Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:56386 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750887AbbEEAv0 (ORCPT ); Mon, 4 May 2015 20:51:26 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2ClBgA4E0hV/38+LHlcgwyBL7QBBplEAgIBAQKBMU0BAQEBAQGBC4QgAQEBBDocIxAIAxUDCSUPBSUDIROIKscKAQEIAgEfGIV/hSKEIGUHhC0FnF6WHyNggSccgWMsMYECgUMBAQE Received: from ppp121-44-62-127.lns20.syd4.internode.on.net (HELO dastard) ([121.44.62.127]) by ipmail07.adl2.internode.on.net with ESMTP; 05 May 2015 10:21:25 +0930 Received: from dave by dastard with local (Exim 4.80) (envelope-from ) id 1YpR4q-0005sd-Ez; Tue, 05 May 2015 10:51:12 +1000 Date: Tue, 5 May 2015 10:51:12 +1000 From: Dave Chinner To: Eric Sandeen Cc: fstests@vger.kernel.org Subject: Re: [PATCH 3/4] xfs/045: can't change UUID on v5 filesystems. Message-ID: <20150505005112.GK15810@dastard> References: <1430776893-25158-1-git-send-email-david@fromorbit.com> <1430776893-25158-4-git-send-email-david@fromorbit.com> <5547F73F.2030303@sandeen.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5547F73F.2030303@sandeen.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, May 04, 2015 at 05:48:31PM -0500, Eric Sandeen wrote: > On 5/4/15 5:01 PM, Dave Chinner wrote: > > From: Dave Chinner > > > > So pass "-m crc=0" to the scratch_mkfs command so that we only run > > on old v4 format filesystems where the UUID can be changed. > > > > Signed-off-by: Dave Chinner > > hm, given that I might "fix" this should we instead trap > on an xfs_db uuid failure, and _notrun the test? > (oh, but older xfs_db let it go, didn't it. sigh). > > I guess nothing about the presence of crc vs. non-crc > matters for this test, so turning it off by default is probably ok. > It could use a comment about why it's got "-m crc=0" though, at > least. Added. New patch below. Reviewed-by: Eric Sandeen diff --git a/tests/xfs/045 b/tests/xfs/045 index 7d8a4a1..2733f5c 100755 --- a/tests/xfs/045 +++ b/tests/xfs/045 @@ -49,8 +49,11 @@ _require_scratch_nocheck echo "*** get uuid" uuid=`_get_existing_uuid` + +# We can only change the UUID on a v4 filesystem. Revist this when/if UUIDs +# can be changed on v5 filesystems. echo "*** mkfs" -if ! _scratch_mkfs_xfs >$tmp.out 2>&1 +if ! _scratch_mkfs_xfs -m crc=0 >$tmp.out 2>&1 then cat $tmp.out echo "!!! failed to mkfs on $SCRATCH_DEV"