From patchwork Wed Mar 15 16:33:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Tulak X-Patchwork-Id: 9626117 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AE18D604A9 for ; Wed, 15 Mar 2017 16:34:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A07F828668 for ; Wed, 15 Mar 2017 16:34:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 944A22866A; Wed, 15 Mar 2017 16:34:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 346EF28668 for ; Wed, 15 Mar 2017 16:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751100AbdCOQee (ORCPT ); Wed, 15 Mar 2017 12:34:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55894 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbdCOQdw (ORCPT ); Wed, 15 Mar 2017 12:33:52 -0400 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1C9E264DA1 for ; Wed, 15 Mar 2017 16:33:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1C9E264DA1 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jtulak@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1C9E264DA1 Received: from honza-mbp.redhat.com (ovpn-204-198.brq.redhat.com [10.40.204.198]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D21C2D655; Wed, 15 Mar 2017 16:33:51 +0000 (UTC) From: Jan Tulak To: fstests@vger.kernel.org Cc: Jan Tulak Subject: [PATCH] xfstests: xfs/191 update Date: Wed, 15 Mar 2017 17:33:47 +0100 Message-Id: <20170315163347.29743-1-jtulak@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.74 on 10.5.11.28 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 15 Mar 2017 16:33:52 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The removed 'do_mkfs_pass -l size=4096b' was against man page (-b section). Other entries are things that weren't covered before. Specifically, a standalone "-l size=4096b" should fail, because: To specify any options on the command line in units of filesys‐ tem blocks, this option must be specified first so that the filesystem block size is applied consistently to all options. Signed-off-by: Jan Tulak --- tests/xfs/191-input-validation | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tests/xfs/191-input-validation b/tests/xfs/191-input-validation index 5de55170..e22f9bfc 100755 --- a/tests/xfs/191-input-validation +++ b/tests/xfs/191-input-validation @@ -114,6 +114,9 @@ do_mkfs_fail -d sectsize=2foo $SCRATCH_DEV do_mkfs_fail -l sectsize=nggh $SCRATCH_DEV do_mkfs_fail -l sectsize=2nggh $SCRATCH_DEV +# option respecification should fail +do_mkfs_fail -d agcount=32,agcount=32 $SCRATCH_DEV + # conflicting sector/block sizes do_mkfs_fail -s size=512 -d sectsize=1024 $SCRATCH_DEV do_mkfs_fail -s size=512 -l sectsize=1024 $SCRATCH_DEV @@ -191,6 +194,12 @@ do_mkfs_fail -d sectsize=512s,agsize=65536s $SCRATCH_DEV reset_fsimg +# some sectsize/blocksize combinations +do_mkfs_pass -s size=512 -b size=8s $SCRATCH_DEV +do_mkfs_fail -s size=512s $SCRATCH_DEV + +reset_fsimg + # file section, should pass do_mkfs_pass $fsimg do_mkfs_pass -d file=0 $SCRATCH_DEV @@ -218,7 +227,6 @@ reset_fsimg # log section, should pass do_mkfs_pass -l size=$logsize -d size=$fssize $SCRATCH_DEV do_mkfs_pass -l agnum=2 $SCRATCH_DEV -do_mkfs_pass -l size=4096b $SCRATCH_DEV do_mkfs_pass -l sectsize=512 $SCRATCH_DEV do_mkfs_pass -l sunit=64 $SCRATCH_DEV do_mkfs_pass -l sunit=64 -d sunit=8,swidth=8 $SCRATCH_DEV @@ -237,6 +245,7 @@ do_mkfs_pass -l version=2 -m crc=0 $SCRATCH_DEV do_mkfs_pass -l version=2 $SCRATCH_DEV # log section, should fail +do_mkfs_fail -l size=4096b $SCRATCH_DEV do_mkfs_fail -l size=${fssize}b $SCRATCH_DEV do_mkfs_fail -l size=${fssize}s $SCRATCH_DEV do_mkfs_fail -l size=${fssize}yerk $SCRATCH_DEV