From patchwork Tue May 16 07:58:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eryu Guan X-Patchwork-Id: 9728485 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2C456602B4 for ; Tue, 16 May 2017 07:58:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D97E28701 for ; Tue, 16 May 2017 07:58:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 10ECA28A09; Tue, 16 May 2017 07:58:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8091A28701 for ; Tue, 16 May 2017 07:58:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751804AbdEPH6t (ORCPT ); Tue, 16 May 2017 03:58:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44748 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751800AbdEPH6s (ORCPT ); Tue, 16 May 2017 03:58:48 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0044E3B46C; Tue, 16 May 2017 07:58:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0044E3B46C Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=eguan@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0044E3B46C Received: from localhost (unknown [10.66.12.173]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C83D18F1E; Tue, 16 May 2017 07:58:47 +0000 (UTC) From: Eryu Guan To: fstests@vger.kernel.org Cc: yangx.jy@cn.fujitsu.com, gwendal@chromium.org, Eryu Guan Subject: [PATCH] build: workaround build failures with old autoconf version Date: Tue, 16 May 2017 15:58:32 +0800 Message-Id: <20170516075832.4612-1-eguan@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 16 May 2017 07:58:48 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Xiao Yang reported that fstests failed to build on RHEL6.9 hosts due to old autoreconf didn't pass -I to aclocal -I. This was fixed by autoconf commit 44fbeef86d03 ("Pass autoreconf -I to aclocal -I"). So call aclocal, autoheader and autoconf directly instead of autoreconf, as what's done in xfsprogs Makefile. Also add include/config.h.in to CONFIGURE, which is generated by autoheader, so it also gets removed by make realclean. Reported-by: Xiao Yang Signed-off-by: Eryu Guan Reviewed-by: Xiao Yang --- Hi Xiao Yang, can you please this patch on your RHEL6 host? It works for me. Hi Gwendal, can you please test if cross-compilation still works for chromeOS? I don't have the chromeOS environment to test.. Thanks! Makefile | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index ebf5c03..dd8d344 100644 --- a/Makefile +++ b/Makefile @@ -41,7 +41,7 @@ endif SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz -CONFIGURE = configure include/builddefs include/config.h \ +CONFIGURE = configure include/builddefs include/config.h include/config.h.in \ aclocal.m4 config.guess config.sub install-sh ltmain.sh \ m4/libtool.m4 m4/ltoptions.m4 m4/ltsugar.m4 m4/ltversion.m4 \ m4/lt~obsolete.m4 @@ -79,8 +79,10 @@ clean: # if configure hasn't run, nothing to clean endif configure: configure.ac - autoreconf --include=m4 - libtoolize -i + libtoolize -cfi + aclocal -I m4 + autoheader + autoconf include/builddefs include/config.h: configure ./configure \