From patchwork Thu Sep 14 06:16:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eryu Guan X-Patchwork-Id: 9952475 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C4DB6602C9 for ; Thu, 14 Sep 2017 06:16:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B735A28820 for ; Thu, 14 Sep 2017 06:16:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AB34D288AD; Thu, 14 Sep 2017 06:16:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 51A4228820 for ; Thu, 14 Sep 2017 06:16:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751335AbdINGQm (ORCPT ); Thu, 14 Sep 2017 02:16:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40680 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbdINGQm (ORCPT ); Thu, 14 Sep 2017 02:16:42 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4986AC04B924; Thu, 14 Sep 2017 06:16:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4986AC04B924 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=eguan@redhat.com Received: from localhost (unknown [10.66.12.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id CA566600C0; Thu, 14 Sep 2017 06:16:39 +0000 (UTC) Date: Thu, 14 Sep 2017 14:16:38 +0800 From: Eryu Guan To: Jeff Layton Cc: fstests@vger.kernel.org, cluster-devel@redhat.com Subject: Re: [xfstests PATCH][RESEND] generic/441: whitelist gfs2 for full test Message-ID: <20170914061638.GF8034@eguan.usersys.redhat.com> References: <20170728104827.7260-1-jlayton@kernel.org> <20170913130400.23185-1-jlayton@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170913130400.23185-1-jlayton@kernel.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 14 Sep 2017 06:16:42 +0000 (UTC) Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Jeff, On Wed, Sep 13, 2017 at 09:04:00AM -0400, Jeff Layton wrote: > From: Jeff Layton > > gfs2 passes the full-scale generic/441 test with the patch that > converts it to use errseq_t reporting for fsync. > > Signed-off-by: Jeff Layton > --- > tests/generic/441 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/generic/441 b/tests/generic/441 > index 075d87723ca1..b98f709cb6eb 100755 > --- a/tests/generic/441 > +++ b/tests/generic/441 > @@ -55,7 +55,7 @@ case $FSTYP in > btrfs) > _notrun "btrfs has a specialized test for this" > ;; > - ext3|ext4|xfs) > + ext3|ext4|gfs2|xfs) Seems you missed my previous reply to this patch on July 31st, or my reply didn't hit the list at all.. Anyway, gfs2 has no external log device support yet in _scratch_mkfs, gfs2 was created with internal log even _has_logdev returned true. So if test still passes with patched gfs2 in this case, I think we can test gfs2 in full-scale mode unconditionally? e.g. ext3|ext4|xfs) # Do the more thorough test if we have a logdev _has_logdev && sflag='' ;; gfs2) # sflag='' ;; *) ;; But I pulled & built the latest Linus tree (which contains commit d07a6ac7b6f8 ("gfs2: convert to errseq_t based writeback error reporting for fsync")), and generic/441 still fails on gfs2 in the full-scale test setup, and this doesn't match the commit log. Are there any additional fixes required? Or did I miss anything? Thanks, Eryu > # Do the more thorough test if we have a logdev > _has_logdev && sflag='' > ;; > -- > 2.13.5 > > -- > To unsubscribe from this list: send the line "unsubscribe fstests" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- tests/generic/441.out 2017-09-05 13:14:52.768000000 +0800 +++ /root/workspace/xfstests/results//gfs2/generic/441.out.bad 2017-09-14 13:03:57.280000000 +0800 @@ -1,3 +1,3 @@ QA output created by 441 Format and mount -Test passed! +Third fsync on fd[0] failed: Input/output error