From patchwork Thu Jan 18 16:07:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Zwisler X-Patchwork-Id: 10173643 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id AB94260230 for ; Thu, 18 Jan 2018 16:07:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A36F128396 for ; Thu, 18 Jan 2018 16:07:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 985302839C; Thu, 18 Jan 2018 16:07:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DF90283FE for ; Thu, 18 Jan 2018 16:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755172AbeARQHp (ORCPT ); Thu, 18 Jan 2018 11:07:45 -0500 Received: from mga07.intel.com ([134.134.136.100]:63103 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754869AbeARQHp (ORCPT ); Thu, 18 Jan 2018 11:07:45 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jan 2018 08:07:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,378,1511856000"; d="scan'208";a="194411036" Received: from theros.lm.intel.com ([10.232.112.164]) by orsmga005.jf.intel.com with ESMTP; 18 Jan 2018 08:07:43 -0800 From: Ross Zwisler To: Eryu Guan , fstests@vger.kernel.org Cc: Ross Zwisler , linux-ext4@vger.kernel.org, linux-nvdimm@lists.01.org, dave.jiang@intel.com Subject: [fstests PATCH v2] generic/347: dm-thin lacks DAX support Date: Thu, 18 Jan 2018 09:07:37 -0700 Message-Id: <20180118160737.24708-1-ross.zwisler@linux.intel.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180118042343.GQ3102@eguan.usersys.redhat.com> Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP generic/347 currently fails when run in conjunction with the DAX mount option: generic/347 72s ... - output mismatch (see /root/project/xfstests/results//generic/347.out.bad) --- tests/generic/347.out 2016-05-12 11:56:32.086618744 -0600 +++ /root/project/xfstests/results//generic/347.out.bad 2018-01-17 16:04:33.459348448 -0700 @@ -1,2 +1,3 @@ QA output created by 347 +mount: /mnt/xfstests_scratch: can't read superblock on /dev/mapper/thin-vol. === completed ... (Run 'diff -u tests/generic/347.out /root/project/xfstests/results//generic/347.out.bad' to see the entire diff) This is expected because the dm-thin target currently lacks DAX support. Just skip this test if we are using DAX. Signed-off-by: Ross Zwisler --- common/dmthin | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/common/dmthin b/common/dmthin index baab6284..da0ad284 100644 --- a/common/dmthin +++ b/common/dmthin @@ -35,6 +35,11 @@ DMTHIN_POOL_DEV="/dev/mapper/$DMTHIN_POOL_NAME" DMTHIN_VOL_NAME="thin-vol" DMTHIN_VOL_DEV="/dev/mapper/$DMTHIN_VOL_NAME" +echo $MOUNT_OPTIONS | grep -q dax +if [ $? -eq 0 ]; then + _notrun "Cannot run tests with DAX on dmthin devices" +fi + _dmthin_cleanup() { $UMOUNT_PROG $SCRATCH_MNT > /dev/null 2>&1