From patchwork Tue May 8 12:56:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 10386113 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3DEAB602D8 for ; Tue, 8 May 2018 12:57:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D29128D13 for ; Tue, 8 May 2018 12:57:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 21BF728DAF; Tue, 8 May 2018 12:57:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DA1C028DAA for ; Tue, 8 May 2018 12:57:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755005AbeEHM5A (ORCPT ); Tue, 8 May 2018 08:57:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:44540 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754817AbeEHM47 (ORCPT ); Tue, 8 May 2018 08:56:59 -0400 Received: from tleilax.poochiereds.net (cpe-71-70-156-158.nc.res.rr.com [71.70.156.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9FEAF214DA; Tue, 8 May 2018 12:56:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1525784219; bh=+9PP4QKDVlug/SBfaeHvDBRcEGfRIfdC4kWZt59m65Y=; h=From:To:Cc:Subject:Date:From; b=oSzNwo6xU2q3V9ukRZ6R4iBAdHA2ue3j33ADUxLpENOm2/CfTFF1jpbyib5AAfyiA 8VP7haF91LwH5Cti8Zk+5FU+/+ZPvP8/nyHKES8DdbIamzVi65NmpGx7ipvJvwIZ+N Vrq1NcSST7FkKFMPoxH54Kij7WpFgN6nZJTKStmU= From: Jeff Layton To: guaneryu@gmail.com Cc: fstests@vger.kernel.org, willy@infradead.org, andres@anarazel.de, david@fromorbit.com, amir73il@gmail.com Subject: [PATCH] btrfs: add test for seeing unseen fsync errors on newly open files Date: Tue, 8 May 2018 08:56:57 -0400 Message-Id: <20180508125657.10045-1-jlayton@kernel.org> X-Mailer: git-send-email 2.17.0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jeff Layton This adds a regression test for the following kernel patch: errseq: Always report a writeback error once This is motivated by some rather odd behavior done by the PostgreSQL project. The main database writers will offload the fsync calls to a separate process, which can open files after a writeback error has already occurred. This used to work with older kernels that reported the error to only one fd, but with the errseq_t changes we lost the ability to see errors that occurred before the open. The above patch restores that behavior. Signed-off-by: Jeff Layton --- tests/btrfs/999 | 110 ++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/999.out | 5 ++ tests/btrfs/group | 1 + 3 files changed, 116 insertions(+) create mode 100755 tests/btrfs/999 create mode 100644 tests/btrfs/999.out diff --git a/tests/btrfs/999 b/tests/btrfs/999 new file mode 100755 index 000000000000..0f68942a91da --- /dev/null +++ b/tests/btrfs/999 @@ -0,0 +1,110 @@ +#! /bin/bash +# FS QA Test No. 999 +# +# Open a file and write to it and fsync. Then flip the data device to throw +# errors, write to it again and call sync. Close the file, reopen it and +# then call fsync on it. Is the error reported? +# +#----------------------------------------------------------------------- +# Copyright (c) 2018, Jeff Layton +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -rf $tmp.* $testdir + _dmerror_cleanup +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/dmerror + +# real QA test starts here +_supported_os Linux +_supported_fs btrfs +# This test uses "dm" without taking into account the data could be on +# realtime subvolume, thus the test will fail with rtinherit=1 +_require_no_rtinherit +_require_scratch_dev_pool + +_require_dm_target error + +rm -f $seqres.full + +# bring up dmerror device +_scratch_unmount +_dmerror_init + +# Replace first device with error-test device +old_SCRATCH_DEV=$SCRATCH_DEV +SCRATCH_DEV_POOL=`echo $SCRATCH_DEV_POOL | perl -pe "s#$SCRATCH_DEV#$DMERROR_DEV#"` +SCRATCH_DEV=$DMERROR_DEV + +echo "Format and mount" +_scratch_pool_mkfs "-d raid0 -m raid1" > $seqres.full 2>&1 +_scratch_mount + +# How much do we need to write? We need to hit all of the stripes. btrfs uses a +# fixed 64k stripesize, so write enough to hit each one. In the case of +# compression, each 128K input data chunk will be compressed to 4K (because of +# the characters written are duplicate). Therefore we have to write +# (128K * 16) = 2048K to make sure every stripe can be hit. +number_of_devices=`echo $SCRATCH_DEV_POOL | wc -w` +write_kb=$(($number_of_devices * 2048)) +_require_fs_space $SCRATCH_MNT $write_kb +datalen=$((($write_kb * 1024)-1)) + +# use fd 5 to hold file open +testfile=$SCRATCH_MNT/fsync-open-after-err +exec 5>$testfile + +# write some data to file and fsync it out +$XFS_IO_PROG -c "pwrite -q 0 $datalen" -c fsync $testfile + +# flip device to non-working mode +_dmerror_load_error_table + +# rewrite the data, call sync to ensure it's written back w/o scraping error +$XFS_IO_PROG -c "pwrite -q 0 $datalen" -c sync $testfile + +# heal the device error +_dmerror_load_working_table + +# open again and call fsync +echo "The following fsync should fail with EIO:" +$XFS_IO_PROG -c fsync $testfile +echo "done" + +# close file +exec 5>&- + +# success, all done +_dmerror_unmount +_dmerror_cleanup + +status=0 +exit diff --git a/tests/btrfs/999.out b/tests/btrfs/999.out new file mode 100644 index 000000000000..38d2d7f6495f --- /dev/null +++ b/tests/btrfs/999.out @@ -0,0 +1,5 @@ +QA output created by 999 +Format and mount +The following fsync should fail with EIO: +fsync: Input/output error +done diff --git a/tests/btrfs/group b/tests/btrfs/group index ba766f6b84f8..8550f87a2305 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -162,3 +162,4 @@ 157 auto quick raid 158 auto quick raid scrub 159 auto quick +999 auto quick