| Message ID | 20180627160355.10348-1-mcgrof@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
diff --git a/tests/Makefile b/tests/Makefile index 2611b3b845f5..11164e9ec130 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -5,7 +5,7 @@ TOPDIR = .. include $(TOPDIR)/include/builddefs -TESTS_SUBDIRS = $(sort $(dir $(wildcard $(PWD)/$(TESTS_DIR)/[a-z]*/))) +TESTS_SUBDIRS = $(sort $(dir $(wildcard $(CURDIR)/[a-z]*/))) include $(BUILDRULES)
If you install with: sudo make install Depending on the system, you may see that /var/lib/xfstests/ installed properly but /var/lib/xfstests/tests/ is empty and so your install really is broken and not functional. Finding out what went wrong is not obvious. The issue is caused due to the fact that $(PWD) is used nad if sudo is used this can be empty on some systems. PWD is only used on one target on the xfstests build system, the tests/*/ dir install target. We can fix this by using $(CURDIR) instead. This issue is observed on both Fedora and OpenSUSE, but not on Debian. Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- tests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)