From patchwork Wed Jun 27 16:03:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 10492149 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 23E3C60386 for ; Wed, 27 Jun 2018 16:03:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5319A29467 for ; Wed, 27 Jun 2018 16:03:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 456782948F; Wed, 27 Jun 2018 16:03:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EA58029467 for ; Wed, 27 Jun 2018 16:03:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934728AbeF0QD5 (ORCPT ); Wed, 27 Jun 2018 12:03:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:41816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934246AbeF0QD5 (ORCPT ); Wed, 27 Jun 2018 12:03:57 -0400 Received: from garbanzo.lan (c-73-71-40-85.hsd1.ca.comcast.net [73.71.40.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97D0825BC1; Wed, 27 Jun 2018 16:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1530115436; bh=aKZe8RmJtByvEBd7icaIMRVQALxAnWh1ryHf+ML5QxM=; h=From:To:Cc:Subject:Date:From; b=NmevXI/qG2w4clAqog7flrWk59RXHpqIFH4LakqdStrPpTu3GtbH6UMqiOi466uNT GIUNf/RzqUqCsCQuIPYxj3Gq81ipx3p9+G8HmkvAw3LEXbYZKIjLyFx/VPhbbjTglc lAhacma0UtSGRX2sm33zSb4U/a6Zqah1g6bvHfjI= From: "Luis R. Rodriguez" To: fstests@vger.kernel.org Cc: "Luis R. Rodriguez" Subject: [PATCH v2] xfstests: fix install target using sudo Date: Wed, 27 Jun 2018 09:03:55 -0700 Message-Id: <20180627160355.10348-1-mcgrof@kernel.org> X-Mailer: git-send-email 2.18.0 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If you install with: sudo make install Depending on the system, you may see that /var/lib/xfstests/ installed properly but /var/lib/xfstests/tests/ is empty and so your install really is broken and not functional. Finding out what went wrong is not obvious. The issue is caused due to the fact that $(PWD) is used nad if sudo is used this can be empty on some systems. PWD is only used on one target on the xfstests build system, the tests/*/ dir install target. We can fix this by using $(CURDIR) instead. This issue is observed on both Fedora and OpenSUSE, but not on Debian. Signed-off-by: Luis R. Rodriguez --- tests/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index 2611b3b845f5..11164e9ec130 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -5,7 +5,7 @@ TOPDIR = .. include $(TOPDIR)/include/builddefs -TESTS_SUBDIRS = $(sort $(dir $(wildcard $(PWD)/$(TESTS_DIR)/[a-z]*/))) +TESTS_SUBDIRS = $(sort $(dir $(wildcard $(CURDIR)/[a-z]*/))) include $(BUILDRULES)