From patchwork Tue Jul 10 12:52:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zorro Lang X-Patchwork-Id: 10516915 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2EA57603D7 for ; Tue, 10 Jul 2018 12:52:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D0B628D5A for ; Tue, 10 Jul 2018 12:52:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 111DA28D82; Tue, 10 Jul 2018 12:52:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A1BDE28D5A for ; Tue, 10 Jul 2018 12:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933267AbeGJMwu (ORCPT ); Tue, 10 Jul 2018 08:52:50 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59990 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933132AbeGJMwu (ORCPT ); Tue, 10 Jul 2018 08:52:50 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FDAC400138A for ; Tue, 10 Jul 2018 12:52:49 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-12-68.pek2.redhat.com [10.72.12.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7BBE81687B for ; Tue, 10 Jul 2018 12:52:48 +0000 (UTC) From: Zorro Lang To: fstests@vger.kernel.org Subject: [PATCH v2] generic/499: filter fsx stderr output Date: Tue, 10 Jul 2018 20:52:43 +0800 Message-Id: <20180710125243.4956-1-zlang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 10 Jul 2018 12:52:49 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Tue, 10 Jul 2018 12:52:49 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'zlang@redhat.com' RCPT:'' Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On some old kernel which supports COLLAPSE_RANGE and ZERO_RANGE, but doesn't support INSERT_RANGE, this case alway fails as: QA output created by 499 +main: filesystem does not support fallocate mode FALLOC_FL_INSERT_RANGE, disabling! Silence is golden fsx print one more line to break the golden image. To fix this issue, redirect both fsx stdout and stderr to a file, then check the return value. Signed-off-by: Zorro Lang Reviewed-by: Lukas Czerner --- Hi, V1 as below (thanks Lukas): https://marc.info/?l=fstests&m=153122545923371&w=2 V2 use "2>&1" to instead of "-I". Thanks, Zorro tests/generic/499 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/generic/499 b/tests/generic/499 index 99d6d308..773eab2e 100755 --- a/tests/generic/499 +++ b/tests/generic/499 @@ -50,7 +50,7 @@ ENDL victim=$SCRATCH_MNT/a touch $victim -$here/ltp/fsx --replay-ops $tmp.fsxops $victim > $tmp.output || cat $tmp.output +$here/ltp/fsx --replay-ops $tmp.fsxops $victim > $tmp.output 2>&1 || cat $tmp.output echo "Silence is golden" status=0