From patchwork Wed Oct 24 07:24:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chao Yu X-Patchwork-Id: 10654269 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 44A5413A4 for ; Wed, 24 Oct 2018 07:24:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2ACB629B5B for ; Wed, 24 Oct 2018 07:24:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1A7EC2A658; Wed, 24 Oct 2018 07:24:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CA8129B5B for ; Wed, 24 Oct 2018 07:24:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726531AbeJXPvf (ORCPT ); Wed, 24 Oct 2018 11:51:35 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:36958 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726449AbeJXPvf (ORCPT ); Wed, 24 Oct 2018 11:51:35 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id ACE9AC3316A6C; Wed, 24 Oct 2018 15:24:42 +0800 (CST) Received: from szvp000201624.huawei.com (10.120.216.130) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.408.0; Wed, 24 Oct 2018 15:24:36 +0800 From: Chao Yu To: , CC: , , Chao Yu Subject: [PATCH v2] generic/508: fix to check inode creation time feature on scratch mountpoint Date: Wed, 24 Oct 2018 15:24:33 +0800 Message-ID: <20181024072433.109167-1-yuchao0@huawei.com> X-Mailer: git-send-email 2.18.0.rc1 MIME-Version: 1.0 X-Originating-IP: [10.120.216.130] X-CFilter-Loop: Reflected Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP _require_btime() just check inode creation time feature on TEST_DIR mountpoint, but generic/508 needs to do that check on SCRATCH_MNT mountpoint. Let's add _require_scratch_btime() for that, meanwhile moving the check behind scratch_mkfs/scratch_moun. Signed-off-by: Chao Yu --- v2: As Dave Chinner suggested: - introduce _require_scratch_btime() to check inode creation time feature in scratch mountpoint, adjust generic/508 to use it. - relocate the check behind scratch_mkfs/scratch_mount. common/rc | 8 ++++++++ tests/generic/508 | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/common/rc b/common/rc index b4987a9cd7f7..111ba5410506 100644 --- a/common/rc +++ b/common/rc @@ -3851,6 +3851,14 @@ _require_btime() rm -f $TEST_DIR/test_creation_time } +_require_scratch_btime() +{ + $XFS_IO_PROG -f $SCRATCH_MNT/test_creation_time -c "statx -v" \ + | grep btime >>$seqres.full 2>&1 || \ + _notrun "inode creation time not supported by this filesystem" + rm -f $SCRATCH_MNT/test_creation_time +} + init_rc ################################################################################ diff --git a/tests/generic/508 b/tests/generic/508 index b869b3a9c260..f1cda52fa44c 100755 --- a/tests/generic/508 +++ b/tests/generic/508 @@ -46,7 +46,6 @@ _supported_os Linux _require_test_lsattr _require_statx _require_xfs_io_command "statx" "-v" -_require_btime _require_scratch _require_scratch_shutdown @@ -59,6 +58,7 @@ testfile=$SCRATCH_MNT/testfile do_check() { _scratch_mount + _require_scratch_btime touch $testfile