diff mbox series

xfs/252: requires fallocate support for preallocation

Message ID 20190205184816.20330-1-hch@lst.de (mailing list archive)
State New, archived
Headers show
Series xfs/252: requires fallocate support for preallocation | expand

Commit Message

Christoph Hellwig Feb. 5, 2019, 6:48 p.m. UTC
xfs/252 has a few feature tests, but misses checking for preallocation
support.  Because of that it will fail instead of not being run for
and XFS file system in always COW mode.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/xfs/252 | 1 +
 1 file changed, 1 insertion(+)

Comments

Eryu Guan Feb. 10, 2019, 9:30 a.m. UTC | #1
On Tue, Feb 05, 2019 at 07:48:16PM +0100, Christoph Hellwig wrote:
> xfs/252 has a few feature tests, but misses checking for preallocation
> support.  Because of that it will fail instead of not being run for
> and XFS file system in always COW mode.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/xfs/252 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/xfs/252 b/tests/xfs/252
> index df795b81..42650ad1 100755
> --- a/tests/xfs/252
> +++ b/tests/xfs/252
> @@ -31,6 +31,7 @@ _supported_fs xfs
>  _supported_os Linux
>  
>  _require_test
> +_require_xfs_io_command "fallocate"

The xfs_io command should be "falloc", fixed on commit :)

Thanks,
Eryu

>  _require_xfs_io_command "fpunch"
>  _require_xfs_io_command "fiemap"
>  
> -- 
> 2.20.1
>
diff mbox series

Patch

diff --git a/tests/xfs/252 b/tests/xfs/252
index df795b81..42650ad1 100755
--- a/tests/xfs/252
+++ b/tests/xfs/252
@@ -31,6 +31,7 @@  _supported_fs xfs
 _supported_os Linux
 
 _require_test
+_require_xfs_io_command "fallocate"
 _require_xfs_io_command "fpunch"
 _require_xfs_io_command "fiemap"