| Message ID | 20190327074509.27770-1-zlang@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xfs/065: make sure SCRATCH_DEV is unmount before mkfs | expand |
On Wed, Mar 27, 2019 at 03:45:09PM +0800, Zorro Lang wrote: > Commit "8309b39a fstests: fix broken _require_scratch usage" did > below change on xfs/065: > > -_scratch_unmount 2>/dev/null > +_scratch_mkfs_xfs >> $seqres.full > > It cause xfs/065 always fails now, as: > QA output created by 065 > mkfs.xfs: /dev/sdb2 contains a mounted filesystem > ... > > So use _require_scratch, to make sure the SCRATCH_DEV is unmounted > before mkfs. > > Signed-off-by: Zorro Lang <zlang@redhat.com> DOH, stupid editor... <grumble> Sorry about that. Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> --D > --- > tests/xfs/065 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/xfs/065 b/tests/xfs/065 > index c0d1ee93..f09bd947 100755 > --- a/tests/xfs/065 > +++ b/tests/xfs/065 > @@ -50,6 +50,7 @@ _list_dir() > # real QA test starts here > _supported_fs xfs > _supported_os Linux > +_require_scratch > > # > # too much hassle to get output matching with quotas turned on > -- > 2.17.2 >
diff --git a/tests/xfs/065 b/tests/xfs/065 index c0d1ee93..f09bd947 100755 --- a/tests/xfs/065 +++ b/tests/xfs/065 @@ -50,6 +50,7 @@ _list_dir() # real QA test starts here _supported_fs xfs _supported_os Linux +_require_scratch # # too much hassle to get output matching with quotas turned on
Commit "8309b39a fstests: fix broken _require_scratch usage" did below change on xfs/065: -_scratch_unmount 2>/dev/null +_scratch_mkfs_xfs >> $seqres.full It cause xfs/065 always fails now, as: QA output created by 065 mkfs.xfs: /dev/sdb2 contains a mounted filesystem ... So use _require_scratch, to make sure the SCRATCH_DEV is unmounted before mkfs. Signed-off-by: Zorro Lang <zlang@redhat.com> --- tests/xfs/065 | 1 + 1 file changed, 1 insertion(+)