From patchwork Fri Sep 20 18:48:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Goldstein X-Patchwork-Id: 11154787 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D98B476 for ; Fri, 20 Sep 2019 18:48:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B77EB208C0 for ; Fri, 20 Sep 2019 18:48:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EHfjpVMV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405396AbfITSsz (ORCPT ); Fri, 20 Sep 2019 14:48:55 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40704 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405208AbfITSsz (ORCPT ); Fri, 20 Sep 2019 14:48:55 -0400 Received: by mail-wr1-f66.google.com with SMTP id l3so7791441wru.7 for ; Fri, 20 Sep 2019 11:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=omoVnZO3PVAdXjwZkB6/8gmYm0Y4Du4HH1wxSpvGbZc=; b=EHfjpVMVMFjxy9BkmHYI261RyTYggym/7ZPQY+L4sy/TycD1EMZJWOp3O39YVh7X9A VTr52yZG4iwg2dtSAc5LKPLO4ieMxhj5xdxoIT+YNdyd0RKp3SCFX+5D127N01j6jJpR xjZFT7pX50A+d5vghlKwl9vu3Cma7h81M/x0v2gqN2lrTA1WOlvFyBys5RDFxEM1Uakr pY5LEXsbdkmHyX1ioo71f1B+Vf38btoBW4YNwlRQfREtHqRaMMIjVuYPYrRCA2kLX5+1 Oejtfi/AqnUrq2sm0HH55pDpxBv10KnLYf9oW2xjo5NtU7UzDyrvanZBGv5KPHzNbbf+ tBHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=omoVnZO3PVAdXjwZkB6/8gmYm0Y4Du4HH1wxSpvGbZc=; b=CsZB0GeooDNPCPfgE3zPe2vJ5RkUL+aeVJwpeo6nwosmCr6bqiXdNNH279VP5TM+f7 TSrW4RgbPMyckMGqmSHjou3tPrGVQG1DGJczpKTs58IVw5aRfwHGvO+tr4Krtu9Icxz/ ujKaLOLDzSwfxfC7Do8Og53Dsn+eMOWbswsdOI8LI0A5aQaNJ66wSqwHT92pl0y469LM W69HI1/Xp9s5yi0apc+vNclhB2nB+sfDWuLbvowplAdWBVn92weYFCOT4LfDgIcI7CsX ZtkDd3OJaENfz1tuSQ28O1jsLHXatFJ1yx5zvKrzE9I3XfDAHNXg/QhwGhUct3iOYd8z DRhA== X-Gm-Message-State: APjAAAXpZt+UCwOqsf4W0GEOTIfPT62N5ZADqww3tdRj5JHxHMqtWUN3 I4gW71PWFOB0smtL2KX9yHs= X-Google-Smtp-Source: APXvYqzfgW4hi2OSl2KwrTqS2dxOKpLSonuDNnLU2DhQwf51dw1LNVN11WQq8M57VN/urzVWMlI65Q== X-Received: by 2002:adf:dc41:: with SMTP id m1mr12068346wrj.46.1569005333256; Fri, 20 Sep 2019 11:48:53 -0700 (PDT) Received: from localhost.localdomain ([5.102.239.49]) by smtp.gmail.com with ESMTPSA id v16sm2080197wrt.12.2019.09.20.11.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2019 11:48:52 -0700 (PDT) From: Amir Goldstein To: Theodore Ts'o Cc: Eryu Guan , fstests@vger.kernel.org Subject: [PATCH][xfstests-bld] build-all: fix acl tools build Date: Fri, 20 Sep 2019 21:48:46 +0300 Message-Id: <20190920184846.18251-1-amir73il@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On a clean do-all buster image getfacl is dynamically linked with libacl.so.1, but the built library is not installed. The installed libacl.so.1 in the image is incompatible with the version of acl tools that we build: root@kvm-xfstests:~# getfacl -n -p xfstests/ getfacl: symbol lookup error: getfacl: undefined symbol: walk_tree Fix this by linking acl tools with the static libacl library. Signed-off-by: Amir Goldstein --- build-all | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/build-all b/build-all index 217ae62..83a1394 100755 --- a/build-all +++ b/build-all @@ -233,12 +233,15 @@ fi if test -z "$SKIP_ACL" ; then build_start "ACL library" + # Specify NO_SOLIB=1 so that libacl is only built as a static + # library. Then acl tools will be statically linked to it, and we won't + # have to install libacl1.so. (cd acl; \ CPPFLAGS="-I$DESTDIR/include" \ CFLAGS="$LCF -I$DESTDIR/include" \ LDFLAGS="$LLF $EXEC_LDFLAGS -L$DESTDIR/lib" \ ./configure $cross --prefix=$DESTDIR --disable-nls; $MAKE_CLEAN ; \ - make $J LDFLAGS="$LLF $EXEC_LLDFLAGS -static -L$DESTDIR/lib" ; \ + make $J NO_SOLIB=1 LDFLAGS="$LLF $EXEC_LLDFLAGS -static -L$DESTDIR/lib" ; \ make $J install) fi