| Message ID | 20190927105233.14926-1-nborisov@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] common/rc: Remove special handing of 'dup' argument for btrfs | expand |
On Fri, Sep 27, 2019 at 01:52:32PM +0300, Nikolay Borisov wrote: > _scratch_pool_mkfs special cases the command executed when 'dup' option > is used when creating a filesystem. This is wrong since 'dup' works > for all profiles and number of devices. This bug manifested while > exercising btrfs' balance argument combinations test. All profile combinations should be valid (mkfs, balance convert) since 4.5-ish, so Reviewed-by: David Sterba <dsterba@suse.com>
diff --git a/common/rc b/common/rc index 9f2c252e5aa5..1b150cbad2f6 100644 --- a/common/rc +++ b/common/rc @@ -885,13 +885,7 @@ _scratch_pool_mkfs() { case $FSTYP in btrfs) - # if dup profile is in mkfs options call _scratch_mkfs instead - # because dup profile only works with single device - if [[ "$*" =~ dup ]]; then - _scratch_mkfs $* - else - $MKFS_BTRFS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV_POOL > /dev/null - fi + $MKFS_BTRFS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV_POOL > /dev/null ;; *) echo "_scratch_pool_mkfs is not implemented for $FSTYP" 1>&2
_scratch_pool_mkfs special cases the command executed when 'dup' option is used when creating a filesystem. This is wrong since 'dup' works for all profiles and number of devices. This bug manifested while exercising btrfs' balance argument combinations test. Signed-off-by: Nikolay Borisov <nborisov@suse.com> --- common/rc | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)