diff mbox series

[2/2] generic/475: skip test when using an external log device

Message ID 20210705040307.3322709-3-tytso@mit.edu (mailing list archive)
State New, archived
Headers show
Series skip tests that don't work with an external log | expand

Commit Message

Theodore Ts'o July 5, 2021, 4:03 a.m. UTC
This test tests log recovery by kicking off fstress on the scratch fs,
then switch out the underlying the device with dm-error to see what
happens when the disk goes down.  But when there is an external log
device writes to the log device still succeed, while writes to the
rest of the file system fail, and this leads to file system
corruption.  So skip this test when there is an external log.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 tests/generic/475 | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series

Patch

diff --git a/tests/generic/475 b/tests/generic/475
index 62894491..4f230430 100755
--- a/tests/generic/475
+++ b/tests/generic/475
@@ -34,6 +34,10 @@  _require_scratch
 _require_dm_target error
 _require_command "$KILLALL_PROG" "killall"
 
+if test "$USE_EXTERNAL" = yes -a ! -z "$SCRATCH_LOGDEV" ; then
+    _notrun "Cannot have external log device"
+fi
+
 echo "Silence is golden."
 
 _scratch_mkfs >> $seqres.full 2>&1