| Message ID | 20210806014938.npfn2ykyirfrdlra@xzhoux.usersys.redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests/xfs: check avail blocks after log recovery on ro mount | expand |
On Fri, Aug 06, 2021 at 09:49:38AM +0800, Murphy Zhou wrote: > And followed by a rw mount. > > Suggested-by: Donald Douwsma <ddouwsma@redhat.com> > Signed-off-by: Murphy Zhou <xzhou@redhat.com> > --- > tests/xfs/175 | 59 +++++++++++++++++++++++++++++++++++++++++++++++ > tests/xfs/175.out | 2 ++ > 2 files changed, 61 insertions(+) > create mode 100755 tests/xfs/175 > create mode 100644 tests/xfs/175.out > > diff --git a/tests/xfs/175 b/tests/xfs/175 > new file mode 100755 > index 00000000..2a79a3d4 > --- /dev/null > +++ b/tests/xfs/175 > @@ -0,0 +1,59 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2021 RedHat All Rights Reserved. > +# > +# FS QA Test 175 > +# > +# Testcase for kernel commit: > +# 50d25484bebe xfs: sync lazy sb accounting on quiesce of read-only mounts > +# > +# After shutdown and readonly mount, a following read-write mount would > +# get wrong number of available blocks. That's a description of the reproduction strategy, but the fault was that unmounting the log on a readonly filesystem doesn't log the sb counters. I think it's worth mentioning that in the description. Thanks for putting together a test case though. :) > +# > +. ./common/preamble > +_begin_fstest shutdown auto quick > + > +# real QA test starts here > + > +_supported_fs xfs > +_require_scratch > + > +_scratch_mkfs > $seqres.full 2>&1 > +mount $SCRATCH_DEV $SCRATCH_MNT _scratch_mount ? Also, you probably want _xfs_force_bdev data $SCRATCH_MNT to force testfile to be created on the data device if the test runner passed -d rtinherit=1 in MKFS_OPTS. > + > +# Write test file > +ls > $SCRATCH_MNT/testfile > +df --output=avail $SCRATCH_MNT >> $seqres.full 2>&1 $DF_PROG > + > +# Shutdown > +$XFS_IO_PROG -x -c "shutdown -f" $SCRATCH_MNT > + > +# Mount ReadOnly > +_scratch_unmount > +_scratch_mount -oro > +df --output=avail $SCRATCH_MNT >> $seqres.full 2>&1 > +# Umount and mount rw > +_scratch_unmount > +_scratch_mount > + > +# Get fdblocks before repair > +fdb1=$(df --output=avail $SCRATCH_MNT | tail -1) > +_scratch_unmount > + > +# Repair > +_repair_scratch_fs >> $seqres.full 2>&1 > + > +# Re-mount > +_scratch_mount > + > +# Get fdblocks after repair > +fdb2=$(df --output=avail $SCRATCH_MNT | tail -1) > + > +echo fdb1 $fdb1 fdb2 $fdb2 >> $seqres.full 2>&1 > + > +[ $fdb1 -ne $fdb2 ] && echo Wrong fdblocks: $fdb1 and $fdb2 Looks reasonable enough to me. --D > + > +# success, all done > +echo "Silence is golden" > +status=0 > +exit > diff --git a/tests/xfs/175.out b/tests/xfs/175.out > new file mode 100644 > index 00000000..3b4af34b > --- /dev/null > +++ b/tests/xfs/175.out > @@ -0,0 +1,2 @@ > +QA output created by 175 > +Silence is golden > -- > 2.20.1 >
diff --git a/tests/xfs/175 b/tests/xfs/175 new file mode 100755 index 00000000..2a79a3d4 --- /dev/null +++ b/tests/xfs/175 @@ -0,0 +1,59 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2021 RedHat All Rights Reserved. +# +# FS QA Test 175 +# +# Testcase for kernel commit: +# 50d25484bebe xfs: sync lazy sb accounting on quiesce of read-only mounts +# +# After shutdown and readonly mount, a following read-write mount would +# get wrong number of available blocks. +# +. ./common/preamble +_begin_fstest shutdown auto quick + +# real QA test starts here + +_supported_fs xfs +_require_scratch + +_scratch_mkfs > $seqres.full 2>&1 +mount $SCRATCH_DEV $SCRATCH_MNT + +# Write test file +ls > $SCRATCH_MNT/testfile +df --output=avail $SCRATCH_MNT >> $seqres.full 2>&1 + +# Shutdown +$XFS_IO_PROG -x -c "shutdown -f" $SCRATCH_MNT + +# Mount ReadOnly +_scratch_unmount +_scratch_mount -oro +df --output=avail $SCRATCH_MNT >> $seqres.full 2>&1 +# Umount and mount rw +_scratch_unmount +_scratch_mount + +# Get fdblocks before repair +fdb1=$(df --output=avail $SCRATCH_MNT | tail -1) +_scratch_unmount + +# Repair +_repair_scratch_fs >> $seqres.full 2>&1 + +# Re-mount +_scratch_mount + +# Get fdblocks after repair +fdb2=$(df --output=avail $SCRATCH_MNT | tail -1) + +echo fdb1 $fdb1 fdb2 $fdb2 >> $seqres.full 2>&1 + +[ $fdb1 -ne $fdb2 ] && echo Wrong fdblocks: $fdb1 and $fdb2 + +# success, all done +echo "Silence is golden" +status=0 +exit diff --git a/tests/xfs/175.out b/tests/xfs/175.out new file mode 100644 index 00000000..3b4af34b --- /dev/null +++ b/tests/xfs/175.out @@ -0,0 +1,2 @@ +QA output created by 175 +Silence is golden
And followed by a rw mount. Suggested-by: Donald Douwsma <ddouwsma@redhat.com> Signed-off-by: Murphy Zhou <xzhou@redhat.com> --- tests/xfs/175 | 59 +++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/175.out | 2 ++ 2 files changed, 61 insertions(+) create mode 100755 tests/xfs/175 create mode 100644 tests/xfs/175.out