| Message ID | 20220625030718.1215980-4-tytso@mit.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Misceillaneous ext4 test fix ups | expand |
On Fri, Jun 24, 2022 at 11:07:16PM -0400, Theodore Ts'o wrote: > Signed-off-by: Theodore Ts'o <tytso@mit.edu> > --- > tests/ext4/045 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/ext4/045 b/tests/ext4/045 > index ee7c0de3..4f0ad4aa 100755 > --- a/tests/ext4/045 > +++ b/tests/ext4/045 > @@ -22,7 +22,7 @@ _supported_fs ext4 > _require_scratch > _require_test_program "t_create_short_dirs" > _require_test_program "t_create_long_dirs" > -_require_dumpe2fs "$DUMPE2FS_PROG" dumpe2fs > +_require_dumpe2fs Thanks, I think it planned to write "_require_command" :) This change is good, but the patch subject: "ext4/045: clean up unnecessary arguments to _require_e2fsprogs" is a little weird, dut to it's not changing "_require_e2fsprogs" (and there's not _require_e2fsprogs). Thanks, Zorro > > echo "Silence is golden" > > -- > 2.31.0 >
On Tue, Jun 28, 2022 at 12:37:16PM +0800, Zorro Lang wrote: > > This change is good, but the patch subject: > "ext4/045: clean up unnecessary arguments to _require_e2fsprogs" > is a little weird, dut to it's not changing "_require_e2fsprogs" (and there's > not _require_e2fsprogs). I've replaced the commit description with: ext4/045: _require_dumpe2fs doesn't take any arguments so remove them - Ted
diff --git a/tests/ext4/045 b/tests/ext4/045 index ee7c0de3..4f0ad4aa 100755 --- a/tests/ext4/045 +++ b/tests/ext4/045 @@ -22,7 +22,7 @@ _supported_fs ext4 _require_scratch _require_test_program "t_create_short_dirs" _require_test_program "t_create_long_dirs" -_require_dumpe2fs "$DUMPE2FS_PROG" dumpe2fs +_require_dumpe2fs echo "Silence is golden"
Signed-off-by: Theodore Ts'o <tytso@mit.edu> --- tests/ext4/045 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)