diff mbox series

gce-xfstests: fix setup iam policy binding

Message ID 20220818071523.928417-1-amir73il@gmail.com (mailing list archive)
State New, archived
Headers show
Series gce-xfstests: fix setup iam policy binding | expand

Commit Message

Amir Goldstein Aug. 18, 2022, 7:15 a.m. UTC 
On a new account setup. gce-xfstests setup failed with error:

  "Failed to add iam policy binding for roles/..."

On the second (verbose) retry, the opertaion succeeds,
but the script still aborts.

Fix a typo in the first invocation of the command.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 run-fstests/util/gce-do-setup | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/run-fstests/util/gce-do-setup b/run-fstests/util/gce-do-setup
index c06a1e9..037068e 100755
--- a/run-fstests/util/gce-do-setup
+++ b/run-fstests/util/gce-do-setup
@@ -141,9 +141,9 @@  function SetupServiceAccount () {
 		   --display-name "$name"
 	if ! run_gcloud projects add-iam-policy-binding "$GCE_PROJECT" \
 	     --member "serviceAccount:$srv_acct" \
-	     --role "projects/$GCE_PROJECT/roles/$role" \
+	     --role "$role" \
 	     --verbosity none >& /dev/null ; then
-	    echo "Failed to add iam policy binding for roles/$role"
+	    echo "Failed to add iam policy binding for role $role"
 	    # Re-run to get error message
 	    run_gcloud projects add-iam-policy-binding "$GCE_PROJECT" \
 		       --member "serviceAccount:$srv_acct" \