diff mbox series

[4/4] g/394: clean up test files

Message ID 20220922134822.1020119-4-preichl@redhat.com (mailing list archive)
State New, archived
Headers show
Series [1/4] common: Fix file leak in _get_max_file_size | expand

Commit Message

Pavel Reichl Sept. 22, 2022, 1:48 p.m. UTC
Clean up test files taking space.

-rwxr-xr-x. 1 root root 1.0G Sep 22 14:58 394.1183899
-rwxr-xr-x. 1 root root 1.0G Sep 22 14:58 394.1183899-1
-rwxr-xr-x. 1 root root    0 sep 22 14:58 394.1183899+1

Signed-off-by: Pavel Reichl <preichl@redhat.com>
---
 tests/generic/394 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zorro Lang Sept. 22, 2022, 3:04 p.m. UTC | #1
On Thu, Sep 22, 2022 at 03:48:22PM +0200, Pavel Reichl wrote:
> Clean up test files taking space.
> 
> -rwxr-xr-x. 1 root root 1.0G Sep 22 14:58 394.1183899
> -rwxr-xr-x. 1 root root 1.0G Sep 22 14:58 394.1183899-1
> -rwxr-xr-x. 1 root root    0 sep 22 14:58 394.1183899+1
> 
> Signed-off-by: Pavel Reichl <preichl@redhat.com>
> ---
>  tests/generic/394 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/394 b/tests/generic/394
> index fc03e2f3..cbc2ce13 100755
> --- a/tests/generic/394
> +++ b/tests/generic/394
> @@ -14,7 +14,7 @@ _cleanup()
>  {
>  	cd /
>  	ulimit -f unlimited
> -	rm -f $tmp.*
> +	rm -f $tmp.* $TEST_DIR/$seq.*

I think you can combine this patch with patch 1/4, due to they're for same
purpose, all due to some fs (e.g. exfat) doesn't support sparse file, so
we need to remove those large files created by truncate. If you find same
issue on other places, better to fix them in same patch.

>  }
>  
>  # Import common functions.
> -- 
> 2.37.3
>
diff mbox series

Patch

diff --git a/tests/generic/394 b/tests/generic/394
index fc03e2f3..cbc2ce13 100755
--- a/tests/generic/394
+++ b/tests/generic/394
@@ -14,7 +14,7 @@  _cleanup()
 {
 	cd /
 	ulimit -f unlimited
-	rm -f $tmp.*
+	rm -f $tmp.* $TEST_DIR/$seq.*
 }
 
 # Import common functions.