diff mbox series

[v2,1/2] generic/61[67]: support SOAK_DURATION

Message ID 20230901145331.GP28186@frogsfrogsfrogs (mailing list archive)
State New, archived
Headers show
Series [v2,1/2] generic/61[67]: support SOAK_DURATION | expand

Commit Message

Darrick J. Wong Sept. 1, 2023, 2:53 p.m. UTC
From: Darrick J. Wong <djwong@kernel.org>

Now that I've finally gotten liburing installed on my test machine, I
can actually test io_uring.  Adapt these two tests to support
SOAK_DURATION so I can add it to that too.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
v2: add to soak group
---
 tests/generic/616 |    3 ++-
 tests/generic/617 |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

Comments

Zorro Lang Sept. 1, 2023, 3:45 p.m. UTC | #1
On Fri, Sep 01, 2023 at 07:53:31AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Now that I've finally gotten liburing installed on my test machine, I
> can actually test io_uring.  Adapt these two tests to support
> SOAK_DURATION so I can add it to that too.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> v2: add to soak group
> ---

Thanks! This version looks good to me,
Reviewed-by: Zorro Lang <zlang@redhat.com>

>  tests/generic/616 |    3 ++-
>  tests/generic/617 |    3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/generic/616 b/tests/generic/616
> index 538b480ba7..5b0b02c5e4 100755
> --- a/tests/generic/616
> +++ b/tests/generic/616
> @@ -8,7 +8,7 @@
>  # fsx ops to limit the testing time to be an auto group test.
>  #
>  . ./common/preamble
> -_begin_fstest auto rw io_uring stress
> +_begin_fstest auto rw io_uring stress soak
>  
>  # Import common functions.
>  . ./common/filter
> @@ -33,6 +33,7 @@ fsx_args+=(-N $nr_ops)
>  fsx_args+=(-p $((nr_ops / 100)))
>  fsx_args+=(-o $op_sz)
>  fsx_args+=(-l $file_sz)
> +test -n "$SOAK_DURATION" && fsx_args+=(--duration="$SOAK_DURATION")
>  
>  run_fsx "${fsx_args[@]}" | sed -e '/^fsx.*/d'
>  
> diff --git a/tests/generic/617 b/tests/generic/617
> index 3bb3112e99..a977870023 100755
> --- a/tests/generic/617
> +++ b/tests/generic/617
> @@ -8,7 +8,7 @@
>  # fsx ops to limit the testing time to be an auto group test.
>  #
>  . ./common/preamble
> -_begin_fstest auto rw io_uring stress
> +_begin_fstest auto rw io_uring stress soak
>  
>  # Import common functions.
>  . ./common/filter
> @@ -39,6 +39,7 @@ fsx_args+=(-r $min_dio_sz)
>  fsx_args+=(-t $min_dio_sz)
>  fsx_args+=(-w $min_dio_sz)
>  fsx_args+=(-Z)
> +test -n "$SOAK_DURATION" && fsx_args+=(--duration="$SOAK_DURATION")
>  
>  run_fsx "${fsx_args[@]}" | sed -e '/^fsx.*/d'
>  
>
diff mbox series

Patch

diff --git a/tests/generic/616 b/tests/generic/616
index 538b480ba7..5b0b02c5e4 100755
--- a/tests/generic/616
+++ b/tests/generic/616
@@ -8,7 +8,7 @@ 
 # fsx ops to limit the testing time to be an auto group test.
 #
 . ./common/preamble
-_begin_fstest auto rw io_uring stress
+_begin_fstest auto rw io_uring stress soak
 
 # Import common functions.
 . ./common/filter
@@ -33,6 +33,7 @@  fsx_args+=(-N $nr_ops)
 fsx_args+=(-p $((nr_ops / 100)))
 fsx_args+=(-o $op_sz)
 fsx_args+=(-l $file_sz)
+test -n "$SOAK_DURATION" && fsx_args+=(--duration="$SOAK_DURATION")
 
 run_fsx "${fsx_args[@]}" | sed -e '/^fsx.*/d'
 
diff --git a/tests/generic/617 b/tests/generic/617
index 3bb3112e99..a977870023 100755
--- a/tests/generic/617
+++ b/tests/generic/617
@@ -8,7 +8,7 @@ 
 # fsx ops to limit the testing time to be an auto group test.
 #
 . ./common/preamble
-_begin_fstest auto rw io_uring stress
+_begin_fstest auto rw io_uring stress soak
 
 # Import common functions.
 . ./common/filter
@@ -39,6 +39,7 @@  fsx_args+=(-r $min_dio_sz)
 fsx_args+=(-t $min_dio_sz)
 fsx_args+=(-w $min_dio_sz)
 fsx_args+=(-Z)
+test -n "$SOAK_DURATION" && fsx_args+=(--duration="$SOAK_DURATION")
 
 run_fsx "${fsx_args[@]}" | sed -e '/^fsx.*/d'