| Message ID | 20231109164947.736069-1-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xfs/146: require fallocate support | expand |
On Thu, Nov 09, 2023 at 05:49:47PM +0100, Christoph Hellwig wrote: > xfs/146 uses the xfs_io falloc subcommand and thus kernel fallocate > support. Ensure the support is present. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Ooooops we really ought to get a static checker for this kind of thing. That would be a much better use of engineer time than someone spinning up yet another syzkaller instance... <cough> Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > tests/xfs/146 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/xfs/146 b/tests/xfs/146 > index 123bdff5..c8268a52 100755 > --- a/tests/xfs/146 > +++ b/tests/xfs/146 > @@ -24,6 +24,7 @@ _begin_fstest auto quick rw realtime > _supported_fs xfs > _require_scratch > _require_realtime > +_require_xfs_io_command "falloc" > _require_test_program "punch-alternating" > > # Format filesystem to get the block size > -- > 2.39.2 > >
On Thu, Nov 09, 2023 at 05:49:47PM +0100, Christoph Hellwig wrote: > xfs/146 uses the xfs_io falloc subcommand and thus kernel fallocate > support. Ensure the support is present. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > tests/xfs/146 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/xfs/146 b/tests/xfs/146 > index 123bdff5..c8268a52 100755 > --- a/tests/xfs/146 > +++ b/tests/xfs/146 > @@ -24,6 +24,7 @@ _begin_fstest auto quick rw realtime > _supported_fs xfs > _require_scratch > _require_realtime > +_require_xfs_io_command "falloc" Thanks, if so, we might need to add this case into "prealloc" group. If you agree that too, I'll add it when I merge it. Reviewed-by: Zorro Lang <zlang@redhat.com> Thanks, Zorro > _require_test_program "punch-alternating" > > # Format filesystem to get the block size > -- > 2.39.2 > >
diff --git a/tests/xfs/146 b/tests/xfs/146 index 123bdff5..c8268a52 100755 --- a/tests/xfs/146 +++ b/tests/xfs/146 @@ -24,6 +24,7 @@ _begin_fstest auto quick rw realtime _supported_fs xfs _require_scratch _require_realtime +_require_xfs_io_command "falloc" _require_test_program "punch-alternating" # Format filesystem to get the block size
xfs/146 uses the xfs_io falloc subcommand and thus kernel fallocate support. Ensure the support is present. Signed-off-by: Christoph Hellwig <hch@lst.de> --- tests/xfs/146 | 1 + 1 file changed, 1 insertion(+)